Skip to content

Remove singleton pattern, add static game class, pool sfx players, cleanup events, docs and more, wip #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Dec 3, 2025
Merged

Remove singleton pattern, add static game class, pool sfx players, cleanup events, docs and more, wip #188

merged 31 commits into from
Dec 3, 2025

Conversation

@valkyrienyanko
Copy link
Contributor

@valkyrienyanko valkyrienyanko commented Dec 2, 2025 •
edited
Loading

Added

  • Added static game class for ease of access to all manager scripts e.g. Game.Scene.SwitchToMainMenu() or Game.Audio.PlaySFX
  • Added convenience methods for scene switching in SceneManager

Removed

  • Removed singleton pattern from all manager scripts (access them through Game.cs now)
  • Removed all GodotUtil namespaces and changed them to __TEMPLATE__

Fixed

  • Fixed Godot not restarting on completing setup process
  • Fixed Godot corrupting [Export]'s after completing setup process
  • Fixed crash from game console being assigned too early in popup menu
  • Fixed SFX players not being cleaned up properly
  • Fixed SFX players in AudioManager not being pooled to save a ton of performance

Documentation

  • All XML documentation in GodotUtils is now exposed (before it was not even showing up)
  • Improved documentation for AudioManager

@valkyrienyanko
Remove singleton pattern from Services
6c1c65e
@valkyrienyanko
Remove singleton pattern from AudioManager
be0af0d
@valkyrienyanko
Remove singleton pattern from SceneManager
11874f0
@valkyrienyanko
Remove singleton pattern from GameConsole
cd7d7c8
@valkyrienyanko
Remove singleton pattern from MetricsOverlay
2bfcac8
@valkyrienyanko
Remove singleton pattern from Profiler
064a778
@valkyrienyanko
Adjust all references to refactored managers
5f57763
@valkyrienyanko
Add static Game class for global managers
9c4c419 
Introduces a static Game class providing global access to core managers and services via the Autoloads singleton.
@valkyrienyanko
Refactor namespaces from GodotUtils to __TEMPLATE__
1df36bb 
Updated all Framework and UI classes to use the __TEMPLATE__ namespace instead of GodotUtils, and adjusted using directives accordingly.
@valkyrienyanko
Improve SFX player cleanup in AudioManager
9f685a4
@valkyrienyanko
Updated documentation for AudioManager.cs
cee6516
@valkyrienyanko
Refactor scene switching to use dedicated methods
3aedf8d 
Introduced dedicated methods in SceneManager for switching to specific menu scenes (MainMenu, Options, ModLoader, Credits) and updated all usages to call these methods instead of accessing MenuScenes directly.
@valkyrienyanko valkyrienyanko self-assigned this Dec 2, 2025
@valkyrienyanko valkyrienyanko changed the title 1.0.7 dev wip Remove singleton pattern, add static game class, cleanup events, docs and more, wip Dec 2, 2025
@valkyrienyanko valkyrienyanko changed the title Remove singleton pattern, add static game class, cleanup events, docs and more, wip Remove singleton pattern, add static game class, pool sfx players, cleanup events, docs and more, wip Dec 3, 2025
@valkyrienyanko
Update GodotUtils.dll
50d2691
@valkyrienyanko
Create GodotUtils.xml
2c60df8
@valkyrienyanko
Pool sfx players in audio manager for performance
c591f87
@valkyrienyanko
Prefer [Export] over unique lookup with %
a8f463e
@valkyrienyanko
Fire and forget on exit game
4301af4
@valkyrienyanko
Catch PreQuit subscriber exceptions
edf2202
@valkyrienyanko
Prefer [Export] over GetNode<T>(...)
d11f2e1
@valkyrienyanko
Update GodotUtils.dll
de63340
@valkyrienyanko
Remove singleton pattern from Logger and more
8866296 
- All messages are dequeued instead of one at a time to prevent backlog buildup
- Removed duplicate ResetColor() calls
- Removed hard game console dependency (optional now)
- Made _messages and _console readonly
@valkyrienyanko
Separate BBColor in its own file from Logger.cs
197160a
@valkyrienyanko
Remove unused code in Logger
6d99181
@valkyrienyanko
Improve readability of Logger by removing lines
4441dc3
@valkyrienyanko
Create BBColor.cs.uid
51727c5
@valkyrienyanko
Call Quit() after Editor.Restart()
5ac9b49
@valkyrienyanko valkyrienyanko merged commit cd31ae6 into main Dec 3, 2025
@valkyrienyanko valkyrienyanko deleted the 1.0.7-dev branch December 3, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@valkyrienyanko valkyrienyanko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@valkyrienyanko