Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
917 changes: 483 additions & 434 deletions app/package-lock.json

Large diffs are not rendered by default.

16 changes: 7 additions & 9 deletions app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,8 @@
"@types/lodash.topairs": "^4.3.7",
"@types/lodash.values": "^4.3.7",
"@types/md5": "^2.3.2",
"@types/react": "^16.14.0",
"@types/react-custom-scroll": "^4.2.0",
"@types/react-dom": "^16.9.8",
"@types/react": "17.0.90",
"@types/react-dom": "18.3.7",
"@types/uuid": "^9.0.1",
"@vitejs/plugin-react": "^6.0.1",
"autoprefixer": "^8.6.5",
Expand Down Expand Up @@ -110,15 +109,14 @@
"lodash.topairs": "^4.3.0",
"lodash.values": "^4.3.0",
"md5": "^2.3.0",
"mobx": "^6.9.0",
"mobx-react": "^7.6.0",
"mobx": "6.15.0",
"mobx-react": "9.2.1",
"prop-types": "^15.8.1",
"react": "^16.14.0",
"react": "18.3.1",
"react-arborist": "3.5.0",
"react-contexify": "^6.0.0",
"react-custom-scroll": "^5.0.0",
"react-dom": "^16.14.0",
"react-dom": "18.3.1",
"react-router-dom": "^6.10.0",
"react-sortable-tree": "^2.8.0",
"tinycolor2": "^1.6.0",
"uuid": "^9.0.0"
}
Expand Down
168 changes: 112 additions & 56 deletions app/src/components/AiDraftModal/AiDraftConversationTreePreview.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
import React, { useEffect, useMemo, useRef, useState } from 'react';
import { Icon } from 'antd';
import { useSize } from 'ahooks';
import SortableTree from 'react-sortable-tree';
import { Tree, NodeRendererProps, RowRendererProps, CursorProps, TreeApi } from 'react-arborist';

import 'react-sortable-tree/style.css';

import { ConverseTekNodeRenderer, ConversationTreeNodeStore, ConverseTekNodeRendererProps } from 'components/DialogEditor/ConverseTekNodeRenderer';
import { ConverseTekNodeRenderer, ConversationTreeNodeStore } from 'components/DialogEditor/ConverseTekNodeRenderer';
import type { OnNodeContextMenuProps } from 'components/DialogEditor/DialogEditor';
import {
buildInitialOpenState,
findConversationTreeMaxRightEdge,
getConversationTreeNodeId,
getConversationTreePath,
getConversationTreeScaffoldLines,
} from 'components/DialogEditor/conversation-tree-adapter';
import { ScalableScrollbar } from 'components/ScalableScrollbar';
import { useStore } from 'hooks/useStore';
import { DataStore } from 'stores/dataStore/data-store';
Expand All @@ -16,6 +21,30 @@ import { getId } from 'utils/conversation-utils';

import 'components/DialogEditor/DialogEditor.css';

const scaffoldBlockPxWidth = 44;
const rootScaffoldOffsetPx = scaffoldBlockPxWidth;

function getPreviewNodeLayoutStyle(style: React.CSSProperties): React.CSSProperties {
const paddingLeft = typeof style.paddingLeft === 'number' ? style.paddingLeft : parseFloat(String(style.paddingLeft || 0));

return {
...style,
paddingLeft: (Number.isNaN(paddingLeft) ? 0 : paddingLeft) + rootScaffoldOffsetPx,
};
}

function PreviewTreeRow({ attrs, innerRef, children }: RowRendererProps<PreviewTreeNode>) {
return (
<div {...attrs} ref={innerRef} className={`${attrs.className || ''} conversation-tree__row`} onFocus={(event) => event.stopPropagation()}>
{children}
</div>
);
}

function PreviewTreeCursor({ top, left }: CursorProps) {
return <div className="conversation-tree__drop-cursor" style={{ top, left }} />;
}

type PreviewNodeStore = ConversationTreeNodeStore & {
buildTreeData: () => PreviewTreeNode[];
recordTreeIndex: (nodeId: string | undefined, treeIndex: number) => void;
Expand All @@ -33,6 +62,7 @@ export function AiDraftConversationTreePreview({ conversationAsset }: Props) {
const dataStore = useStore<DataStore>('data');
const defStore = useStore<DefStore>('def');
const treeContainerRef = useRef<HTMLDivElement>(null);
const arboristTreeRef = useRef<TreeApi<PreviewTreeNode> | null>(null);
const treeContainerSize = useSize(treeContainerRef);
const expansionByNodeId = useRef(new Map<string, boolean>());
const maxHorizontalNodePositionRef = useRef(0);
Expand All @@ -55,7 +85,7 @@ export function AiDraftConversationTreePreview({ conversationAsset }: Props) {

useEffect(() => {
const animationFrameId = requestAnimationFrame(() => {
const nextMaxPosition = findMaxRightEdge(treeContainerRef.current);
const nextMaxPosition = findConversationTreeMaxRightEdge(treeContainerRef.current);
setMaxHorizontalNodePosition((previousMaxPosition) => {
const measuredMaxPosition = Math.max(previousMaxPosition, nextMaxPosition);
maxHorizontalNodePositionRef.current = measuredMaxPosition;
Expand All @@ -73,6 +103,64 @@ export function AiDraftConversationTreePreview({ conversationAsset }: Props) {
const ignoreContextMenu = ({ event }: OnNodeContextMenuProps) => {
event.preventDefault();
};
const getPreviewTreeNodeId = (node: PreviewTreeNode) => node.previewTreeKey || getConversationTreeNodeId(node);
const initialOpenState = buildInitialOpenState(treeData, getPreviewTreeNodeId);
const PreviewNodeRenderer = (props: NodeRendererProps<PreviewTreeNode>) => {
const { node, tree, style } = props;
const treeNode = node.data;
const treeIndex = node.rowIndex ?? 0;
previewNodeStore.recordTreeIndex(treeNode.id, treeIndex);

const comment = getPreviewNodeComment(treeNode, previewNodeStore);

return (
<ConverseTekNodeRenderer
dataStore={dataStore}
nodeStore={previewNodeStore}
activeNodeId={activeNodeId}
previousNodeId={null}
onNodeContextMenu={ignoreContextMenu}
isContextMenuVisible={false}
scaffoldBlockPxWidth={scaffoldBlockPxWidth}
toggleChildrenVisibility={
treeNode.children && treeNode.children.length > 0
? ({ node: currentNode }: { node: RSTNode; path: RSTPath; treeIndex: number }) => {
const arboristNode = tree.get(getPreviewTreeNodeId(currentNode as PreviewTreeNode));
if (arboristNode == null) return;

arboristNode.toggle();
previewNodeStore.setNodeExpansion(currentNode.id, !arboristNode.isOpen);
}
: null
}
connectDragPreview={(element: JSX.Element) => element}
connectDragSource={(element: JSX.Element) => element}
isDragging={false}
canDrop={false}
canDrag={false}
node={{ ...treeNode, expanded: node.isOpen }}
title={treeNode.title}
subtitle={treeNode.subtitle || null}
draggedNode={null}
path={getConversationTreePath(node)}
treeIndex={treeIndex}
isSearchMatch={false}
isSearchFocus={false}
buttons={[]}
className={comment ? 'ai-draft-preview-tree__row--has-comment' : ''}
style={getPreviewNodeLayoutStyle(style)}
didDrop={false}
treeId="ai-draft-preview-tree"
isOver={false}
parentNode={node.parent == null || node.parent.isRoot ? null : node.parent.data}
rowDirection="ltr"
scaffoldLines={getConversationTreeScaffoldLines(node, scaffoldBlockPxWidth)}
rowCommentTooltip={comment}
zoomLevel={1}
operationDefinitions={defStore.operations}
/>
);
};

return (
<div className="ai-draft-preview-tree">
Expand All @@ -85,38 +173,26 @@ export function AiDraftConversationTreePreview({ conversationAsset }: Props) {
<div ref={treeContainerRef} className="ai-draft-preview-tree__canvas dialog-editor">
{treeData.length > 0 && treeWidth > 0 && (
<ScalableScrollbar activeNodeId={activeNodeId} width={10} hideScrollOnScale={false}>
<SortableTree
treeData={treeData}
onChange={(nextTreeData: PreviewTreeNode[]) => setTreeData(nextTreeData)}
getNodeKey={({ node, treeIndex }: { node: PreviewTreeNode; treeIndex: number }) => {
previewNodeStore.recordTreeIndex(node.id, treeIndex);
return node.previewTreeKey || node.id || treeIndex;
}}
<Tree<PreviewTreeNode>
ref={arboristTreeRef}
data={treeData}
idAccessor={getPreviewTreeNodeId}
childrenAccessor={(node) => (node.children || null) as readonly PreviewTreeNode[] | null}
initialOpenState={initialOpenState}
rowHeight={40}
canDrag={() => false}
canDrop={() => false}
generateNodeProps={({ node }: { node: PreviewTreeNode }) => {
const comment = getPreviewNodeComment(node, previewNodeStore);
return {
dataStore,
nodeStore: previewNodeStore,
activeNodeId,
previousNodeId: null,
onNodeContextMenu: ignoreContextMenu,
isContextMenuVisible: false,
buttons: [],
className: comment ? 'ai-draft-preview-tree__row--has-comment' : '',
rowCommentTooltip: comment,
zoomLevel: 1,
operationDefinitions: defStore.operations,
};
}}
nodeContentRenderer={(rendererProps: ConverseTekNodeRendererProps) => <ConverseTekNodeRenderer {...rendererProps} />}
reactVirtualizedListProps={{
width: treeWidth,
}}
slideRegionSize={100}
/>
indent={scaffoldBlockPxWidth}
width={treeWidth}
height={treeContainerSize?.height || 0}
disableDrag
disableDrop
disableMultiSelection
renderRow={PreviewTreeRow}
renderCursor={PreviewTreeCursor}
className="conversation-tree__list"
dndRootElement={treeContainerRef.current}
>
{PreviewNodeRenderer}
</Tree>
</ScalableScrollbar>
)}
</div>
Expand Down Expand Up @@ -196,26 +272,6 @@ function createPreviewNodeStore(
return previewNodeStore;
}

function findMaxRightEdge(node: HTMLElement | null): number {
let maxRight = 0;
if (node == null) return maxRight;

node.childNodes.forEach((child) => {
if (!(child instanceof HTMLElement)) return;

if (child.classList.contains('rst__rowWrapper')) {
const rect = child.getBoundingClientRect();
const left = child.parentElement?.parentElement?.style.left;
const leftValue = left ? parseFloat(left) : 0;
maxRight = Math.max(maxRight, rect.width + leftValue);
}

maxRight = Math.max(maxRight, findMaxRightEdge(child));
});

return maxRight;
}

function buildElementTreeNode(
elementNode: ElementNodeType,
type: 'root' | 'response',
Expand Down
11 changes: 9 additions & 2 deletions app/src/components/AiDraftModal/AiDraftModal.css
Original file line number Diff line number Diff line change
Expand Up @@ -653,7 +653,7 @@
cursor: default;
}

.ai-draft-preview-tree__canvas .ReactVirtualized__Grid {
.ai-draft-preview-tree__canvas .conversation-tree__list {
overflow-x: scroll !important;
overflow-y: auto !important;
scrollbar-gutter: stable;
Expand All @@ -663,6 +663,13 @@
position: relative;
}

.ai-draft-preview-tree__canvas .conversation-node-renderer:has(.node-renderer__comment-handle:hover),
.ai-draft-preview-tree__canvas .conversation-node-renderer__node-content:has(.node-renderer__comment-handle:hover),
.ai-draft-preview-tree__canvas .rst__rowWrapper:has(.node-renderer__comment-handle:hover),
.ai-draft-preview-tree__canvas .ai-draft-preview-tree__row--has-comment:has(.node-renderer__comment-handle:hover) {
z-index: 200;
}

.ai-draft-preview-tree__canvas .node-renderer__comment-handle {
position: relative;
overflow: visible;
Expand Down Expand Up @@ -713,7 +720,7 @@
position: absolute;
top: 100%;
left: 4px;
z-index: 40;
z-index: 220;
width: max-content;
max-width: min(560px, 60vw);
height: auto;
Expand Down
Loading
Loading