Skip to content

add package lock #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 20, 2024
Merged

add package lock #398

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e347e1e
fix: add package-lock and run npm ci in CI
emilefokkemanavara Nov 17, 2024
3c388d0
exclude node types and types in dist
emilefokkemanavara Nov 17, 2024
31af98f
replace package-lock by pnpm-lock
emilefokkemanavara Nov 18, 2024
3538e76
add node types to tsconfig
emilefokkemanavara Nov 18, 2024
ac1a605
update ci to call pnpm instead of npm
emilefokkemanavara Nov 18, 2024
c7ddec3
add dev dependency on node types
emilefokkemanavara Nov 18, 2024
21bbae4
remove package-lock from examples directory
emilefokkemanavara Nov 18, 2024
1d603d8
add pnpm-lock to examples directory
emilefokkemanavara Nov 18, 2024
5dd0150
also do pnpm install in exmples directory
emilefokkemanavara Nov 18, 2024
5874d66
update the deploy action to use pnpm
emilefokkemanavara Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ jobs:
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm run build --if-present
- run: npm run lint
- run: npm test
- uses: pnpm/action-setup@v4
with:
version: 9
- run: pnpm install
- run: pnpm install
working-directory: examples
- run: pnpm run build
- run: pnpm run lint
- run: pnpm run test
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ npm-debug.log
.DS_Store
dist
*.tgz
package-lock.json
package-lock.json
53 changes: 0 additions & 53 deletions examples/package-lock.json
View file
Open in desktop

This file was deleted.

309 changes: 309 additions & 0 deletions examples/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"homepage": "https://github.com/cachecontrol/json-rules-engine",
"devDependencies": {
"@eslint/js": "^9.13.0",
"@types/node": "^22.9.0",
"eslint": "^9.13.0",
"globals": "^15.11.0",
"lodash": "4.17.21",
Expand Down
Loading
Loading