Add sanity-check notebook for analyze_traps with injected localized singular mode#392
Open
charlesmartin14 wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
analyze_trapsdetection of a single injected localized singular mode in a dense matrix.analyze_trapsworkflow.Description
notebooks/analyze_traps_iid_gaussian_sanity.ipynbwhich builds a200 x 400IID Gaussian matrix and injects one highly localized singular vector pair and an amplified singular value.OneLayerMatrixnn.Module, then callwatcher.randomize_modelandwatcher.analyze_trapsto detect traps and computeleft_top_mass,right_top_mass, andtop_5_massmetrics.top_k_mass,localization_ratio) for the injected vectors, assert close agreement with observed trap metrics, and exerciseanalyze_traps(plot=True)to generate plots.Testing
analyze_trapswithreturn_artifacts=Trueandplot=Truein the notebook to ensure both code paths execute without error.Codex Task