forked from pimcore/data-hub
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve mock data handling #27
Open
das-peter
wants to merge
23
commits into
pimcore-x-webonyx-features
Choose a base branch
from
chore/improve-mock-data-handling
base: pimcore-x-webonyx-features
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: Improve mock data handling #27
das-peter
wants to merge
23
commits into
pimcore-x-webonyx-features
from
chore/improve-mock-data-handling
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faef22f
to
b5f0b32
Compare
…her usage of mock objects avoiding db loads.
eeb69c0
to
0912499
Compare
e7d5f41
to
945842d
Compare
…entMockupInterface which allows to handle everything and not just objects / products like \Pimcore\Bundle\EcommerceFrameworkBundle\Model\DefaultMockup.
…ill allow to select appropriate pre-processed data depending on execution context.
…esolve pre-processed data otherwise we might miss multiple call signatures of the same operation.
…esn't seem a real need to check the same element over and over again in the same request.
…e call flow - in the best case this saves an entire call to the search index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.