Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This is a followup of pimcore#14688 as we've had troubles that still some tmp files fill up our storage.
In the above PR the solution is to delete tmp files in my understanding like following:
if a Temp-File gets created via
File::getLocalTempFilePath()
https://github.com/pimcore/pimcore/blob/10.6/lib/File.php#L237 then the path of the tmp file is registered and gets cleanup either by:For example if the PHP process has a Segfault or if your container (in our case a Pod) has a memory overflow also the shutdown function is not executed so the tmp file lives forever in your storage.
To overcome this I implemented a simple clean up task in a general way to clean up a configured directory with all files older than a configured value. As default I added both tmp directories where old files always should be deletable.
In the same move I also cleaned up the HousekeepingTask and removed some old references where in the newly created Task is used.
It is lean against some part that exists back in V6.9: https://github.com/pimcore/pimcore/blob/6.9/lib/Maintenance/Tasks/HousekeepingTask.php#L48
Resolves #
Additional info
WHAT
copilot:summary
copilot:poem
HOW
copilot:walkthrough