-
Notifications
You must be signed in to change notification settings - Fork 98
feat(ibis): postgreSQL, PostGIS support for IBIS Server. #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1da65b7
PostgreSQL, PostGIS support.
eren-ture 5c8957e
Added a test dataset for Geometry type, and added a test case to test…
eren-ture 4dc8002
Added missing assert
eren-ture d71e3e7
Accepted @goldmedal s suggestions.
eren-ture dea0da1
Fixed PostGIS Docker Image and test case.
eren-ture ec18377
Added the required python dependencies for the Geo functions. Added a…
eren-ture a79b58f
Updated poetry.lock for ibis-server
eren-ture 3ae6bfb
Merge branch 'main' into PostGIS-Support
eren-ture 5d5c1d6
PostgreSQL, PostGIS support.
eren-ture c3335ff
Added a test dataset for Geometry type, and added a test case to test…
eren-ture f819515
Added missing assert
eren-ture 86bb245
Accepted @goldmedal s suggestions.
eren-ture 7e6bb0f
Fixed PostGIS Docker Image and test case.
eren-ture e20d7e8
Added the required python dependencies for the Geo functions. Added a…
eren-ture 36ea433
Updated poetry.lock for ibis-server
eren-ture dfec903
Rebase with main
eren-ture 2d97880
Re-ran poetry lock.
eren-ture File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify extension handler augmentation behavior
The
augment
method signature returns a list of tables, but it's being used here to modify theunique_tables
dictionary. Since Python dictionaries are passed by reference, this likely works as intended, but it would be clearer if the method returned the modified dictionary or the variable assignment was removed.🏁 Script executed:
Length of output: 1566
🏁 Script executed:
Length of output: 3870
🏁 Script executed:
Length of output: 19056
Fix type annotations for ExtensionHandler.augment and handlers
The
augment
and related handler methods actually accept and return a mapping of table names toTable
objects (adict[str, Table]
), not alist[Table]
. Update the type signatures to reflect that, or else change the implementation to work with lists:• In ibis-server/app/model/metadata/postgres.py, adjust:
• Optionally remove the assignment
Since the handlers mutate the dict in place and then return it, you could also call:
without re-assigning
unique_tables
.These changes will make the code’s behavior and its annotations consistent.