Skip to content

Disable generating Gif sharable links #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Disable generating Gif sharable links #1287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e5e206
fix
oscartbeaumont Oct 23, 2025
b885f24
nit
oscartbeaumont Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 68 additions & 41 deletions apps/desktop/src/routes/editor/ExportDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import {
commands,
type ExportCompression,
type ExportSettings,
events,
type FramesRendered,
type UploadProgress,
} from "~/utils/tauri";
Expand Down Expand Up @@ -133,6 +132,10 @@ export function ExportDialog() {

if (!["Mp4", "Gif"].includes(settings.format)) setSettings("format", "Mp4");

// Ensure GIF is not selected when exportTo is "link"
if (settings.format === "Gif" && settings.exportTo === "link")
setSettings("format", "Mp4");

const exportWithSettings = (onProgress: (progress: FramesRendered) => void) =>
exportVideo(
projectPath,
Expand Down Expand Up @@ -160,8 +163,6 @@ export function ExportDialog() {

const [outputPath, setOutputPath] = createSignal<string | null>(null);

const selectedStyle = "bg-gray-7";

const projectPath = editorInstance.path;

const exportEstimates = createQuery(() => ({
Expand Down Expand Up @@ -496,7 +497,20 @@ export function ExportDialog() {
<For each={EXPORT_TO_OPTIONS}>
{(option) => (
<Button
onClick={() => setSettings("exportTo", option.value)}
onClick={() => {
setSettings(
produce((newSettings) => {
newSettings.exportTo = option.value;
// If switching to link and GIF is selected, change to MP4
if (
option.value === "link" &&
settings.format === "Gif"
) {
newSettings.format = "Mp4";
}
}),
);
}}
data-selected={settings.exportTo === option.value}
class="flex flex-1 gap-2 items-center text-nowrap"
variant="gray"
Expand All @@ -515,49 +529,62 @@ export function ExportDialog() {
<h3 class="text-gray-12">Format</h3>
<div class="flex flex-row gap-2">
<For each={FORMAT_OPTIONS}>
{(option) => (
<Button
variant="gray"
onClick={() => {
setSettings(
produce((newSettings) => {
newSettings.format = option.value as ExportFormat;
{(option) => {
const isGifDisabled = () =>
option.value === "Gif" && settings.exportTo === "link";

if (
option.value === "Gif" &&
!(
settings.resolution.value === "720p" ||
settings.resolution.value === "1080p"
return (
<Button
variant="gray"
disabled={isGifDisabled()}
onClick={() => {
if (isGifDisabled()) return;
setSettings(
produce((newSettings) => {
newSettings.format =
option.value as ExportFormat;

if (
option.value === "Gif" &&
!(
settings.resolution.value === "720p" ||
settings.resolution.value === "1080p"
)
)
)
newSettings.resolution = {
...RESOLUTION_OPTIONS._720p,
};
newSettings.resolution = {
...RESOLUTION_OPTIONS._720p,
};

if (
option.value === "Gif" &&
GIF_FPS_OPTIONS.every(
(v) => v.value === settings.fps,
if (
option.value === "Gif" &&
GIF_FPS_OPTIONS.every(
(v) => v.value === settings.fps,
)
)
)
newSettings.fps = 15;
newSettings.fps = 15;

if (
option.value === "Mp4" &&
FPS_OPTIONS.every(
(v) => v.value !== settings.fps,
if (
option.value === "Mp4" &&
FPS_OPTIONS.every(
(v) => v.value !== settings.fps,
)
)
)
newSettings.fps = 30;
}),
);
}}
autofocus={false}
data-selected={settings.format === option.value}
>
{option.label}
</Button>
)}
newSettings.fps = 30;
}),
);
}}
autofocus={false}
data-selected={settings.format === option.value}
class={
isGifDisabled()
? "opacity-50 cursor-not-allowed"
: ""
}
>
{option.label}
</Button>
);
}}
</For>
</div>
</div>
Expand Down