Skip to content

V2 Clients Page - #1240

Open
Rabi94 wants to merge 7 commits into
mainfrom
clients-browser-v2
Open

V2 Clients Page#1240
Rabi94 wants to merge 7 commits into
mainfrom
clients-browser-v2

Conversation

@Rabi94

@Rabi94 Rabi94 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

This PR introduces the new V2 Clients Browser page using the shared V2 architecture and MUI X DataGrid.

V2

Screenshot (1283)

V1
Screenshot (1281)

@Rabi94
Rabi94 marked this pull request as ready for review July 20, 2026 17:25
@Rabi94
Rabi94 requested a review from PabloDinella as a code owner July 20, 2026 17:25

@PabloDinella PabloDinella left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging we need to work on filters performance. Filtering by name with 800+ rows practically crashes my browser.

@Rabi94
Rabi94 marked this pull request as draft July 24, 2026 14:19
@Rabi94

Rabi94 commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

@PabloDinella The performance issue wasn't caused by the name filter itself, but by the amount of work performed on every keystroke. Each search update triggered the entire ViewModel pipeline, including filtering, sorting, rebuilding presentation rows, computing assignment/custom field display values, and forcing the DataGrid to process a brand-new set of row objects.
To address this, I split the pipeline into two stages. Presentation rows are now built and cached independently from filtering, allowing search to operate on cached display data instead of rebuilding it for every keypress. I also introduced useDeferredValue to keep typing responsive while React schedules the more expensive filtering work, and stabilized several DataGrid props to reduce unnecessary re-renders.
The overall behavior, permissions, sorting, and filtering logic remain unchanged, but the amount of synchronous work performed during search has been significantly reduced, resulting in a much more responsive experience for larger organizations.

@Rabi94
Rabi94 marked this pull request as ready for review July 27, 2026 17:54
@Rabi94
Rabi94 requested a review from PabloDinella July 28, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants