Improve footer #4#22
Conversation
AJaccP
left a comment
AJaccP
left a comment
There was a problem hiding this comment.
Changes mostly look good, left a couple of minor comments for fixes before merging!
| <div class="bg-accent/80 h-0.5 w-full"></div> | ||
| <div class="site-container py-6">Carleton Computer Science Society</div> | ||
| <div | ||
| class="mx-auto flex max-w-5xl flex-col items-center gap-2 px-4 py-4 sm:flex-row sm:justify-between" |
There was a problem hiding this comment.
The mx-auto max-w-5xl px-4 classes instead of site-container make the footer content unaligned with the main and header content on desktop. Looking at the preview, I think just having site-container handle the spacing would look cleaner, so please remove the 3 classes I pointed out at the beginning and replace with just site-container
To verify this is actually right, the text on the left and right should be aligned with the header's left and right bits and the width of the main content on desktop width.
| href="https://ccss.carleton.ca" | ||
| target="_blank" | ||
| rel="noopener" | ||
| class="hover:text-accent underline-offset-2 hover:underline" |
There was a problem hiding this comment.
Right now the hover behaviour is inconsistent between this and the Github link (this one underlines, the Github links doesn't). Please make them consistent by removing the underline here so it just turns red on hover (consistent with other links on the site as well)
2 participants
No description provided.