Skip to content

fix to prevent reaching file name length limit #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: cdb
Choose a base branch
from
Open

fix to prevent reaching file name length limit #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4f1906
Merge pull request #1 from CartoDB/cdb
mbektash Dec 7, 2016
6c50b9d
fix for file name length limit problem
mbektas Dec 7, 2016
0989100
use md5 once
mbektas Dec 8, 2016
683aa21
Merge pull request #2 from bloomberg/long_name_fix
mbektash Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions app/models/formats/ogr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ OgrFormat.prototype = {
getFileExtension: function(){ return this._fileExtension; },

getKey: function(options) {
return [this.id,
return this.generateMD5([this.id,
options.dbopts.dbname,
options.dbopts.user,
options.gn,
this.generateMD5(options.filename),
this.generateMD5(options.sql)].concat(options.skipfields).join(':');
options.filename,
options.sql].concat(options.skipfields).join(':'));
},

generateMD5: function (data){
Expand Down Expand Up @@ -219,14 +219,14 @@ OgrFormat.prototype.toOGR_SingleFile = function(options, fmt, callback) {
var layername = options.filename;

var tmpdir = global.settings.tmpDir || '/tmp';
var reqKey = [
var reqKey = this.generateMD5([
fmt,
dbname,
user_id,
gcol,
this.generateMD5(layername),
this.generateMD5(sql)
].concat(skipfields).join(':');
layername,
sql
].concat(skipfields).join(':'));
var outdirpath = tmpdir + '/sqlapi-' + process.pid + '-' + reqKey;
var dumpfile = outdirpath + ':cartodb-query.' + ext;

Expand Down
2 changes: 1 addition & 1 deletion app/models/formats/ogr/shp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ ShpFormat.prototype.toSHP = function (options, callback) {
var fmtObj = this;
var zip = 'zip'; // FIXME: make configurable
var tmpdir = global.settings.tmpDir || '/tmp';
var reqKey = [ 'shp', dbname, user_id, gcol, this.generateMD5(sql) ].concat(skipfields).join(':');
var reqKey = this.generateMD5([ 'shp', dbname, user_id, gcol, sql ].concat(skipfields).join(':'));
var outdirpath = tmpdir + '/sqlapi-' + process.pid + '-' + reqKey;
var zipfile = outdirpath + '.zip';
var shapefile = outdirpath + '/' + filename + '.shp';
Expand Down