-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port over fetchMap tests #127
base: felix/fetchmap-implementation
Are you sure you want to change the base?
Conversation
src/fetchMap/index.ts
Outdated
export * from './layer-map.js'; | ||
export * from './parse-map.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional - if something is included only for testing I'm trying to add @internal
TSDoc annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there is a way to avoid having to export these at all? In the deck.gl repo it is possible to "reach into" the source, like this: https://github.com/visgl/deck.gl/blob/master/test/modules/carto/api/basemap.spec.ts#L8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we could configure Vitest and tsconfig.json to allow that, too. The downside is that we'd be unit testing uncompiled code, and very occasionally that could matter.
Perhaps the alternative would be to do something like https://github.com/antfu/vitest-package-exports, and test that any changes to internal vs. non-external package exports are 'expected'?
2e0d511
to
e42747d
Compare
f30d22f
to
5554be9
Compare
5219798
to
458538f
Compare
For #124
Change list