setup show/hide routes at module start and convert to express v5 paths#20
Open
klaernie wants to merge 2 commits into
Open
setup show/hide routes at module start and convert to express v5 paths#20klaernie wants to merge 2 commits into
klaernie wants to merge 2 commits into
Conversation
setting them up when receiving the CONFIG notification doesn't seem to work anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the node_helper to register the routes to show and hide instances to register during the start, instead of setting them up later.
Also MagicMirror² switched to express v5 now, so the path syntax had to be changed, so it keeps working.