Various implimentations and fixes

.gitignore

@@ -326,3 +326,4 @@ ehthumbs.db
 # OpenDream-generated files for TestGame
 TestGame/preprocessor_dump.dm
 TestGame/environment.dmd
+/.tmp-build

Content.Tests/AppearanceOffsetTests.cs

@@ -0,0 +1,88 @@
+using NUnit.Framework;
+using OpenDreamShared.Dream;
+using Robust.Shared.Maths;
+
+namespace Content.Tests;
+
+[TestFixture]
+public sealed class AppearanceOffsetTests {
+    [Test]
+    public void IconOffsetActsAsNegativePixelWZ() {
+        MutableAppearance appearance = MutableAppearance.Get();
+        try {
+            appearance.PixelOffset = new Vector2i(1, 2);
+            appearance.PixelOffset2 = new Vector2i(8, 16);
+            appearance.IconOffset = new Vector2i(3, 5);
+
+            var immutable = new ImmutableAppearance(appearance, null);
+
+            Assert.That(immutable.GetTotalPixelOffset(MapFormat.Side), Is.EqualTo(new Vector2i(6, 13)));
+        } finally {
+            appearance.Dispose();
+        }
+    }
+
+    [Test]
+    public void SideMapRootIconsApplyBoundingBoxAnchor() {
+        MutableAppearance appearance = MutableAppearance.Get();
+        try {
+            appearance.PixelOffset2 = new Vector2i(8, 16);
+            appearance.IconOffset = new Vector2i(3, 5);
+
+            var immutable = new ImmutableAppearance(appearance, null);
+
+            Assert.That(
+                AppearancePositioning.GetPixelOffset(immutable, MapFormat.Side, new Vector2i(32, 32), new Vector2i(4, 7), true),
+                Is.EqualTo(new Vector2i(9, 18)));
+        } finally {
+            appearance.Dispose();
+        }
+    }
+
+    [Test]
+    public void IsometricRootIconsAnchorByLeftCorner() {
+        MutableAppearance appearance = MutableAppearance.Get();
+        try {
+            var immutable = new ImmutableAppearance(appearance, null);
+
+            Assert.That(
+                AppearancePositioning.GetPixelOffset(immutable, MapFormat.Isometric, new Vector2i(32, 64), Vector2i.Zero, true),
+                Is.EqualTo(new Vector2i(0, -32)));
+        } finally {
+            appearance.Dispose();
+        }
+    }
+
+    [Test]
+    public void OverlaysDoNotApplyRootMapFormatAnchors() {
+        MutableAppearance appearance = MutableAppearance.Get();
+        try {
+            var immutable = new ImmutableAppearance(appearance, null);
+
+            Assert.That(
+                AppearancePositioning.GetPixelOffset(immutable, MapFormat.Isometric, new Vector2i(32, 64), new Vector2i(9, 11), false),
+                Is.EqualTo(Vector2i.Zero));
+        } finally {
+            appearance.Dispose();
+        }
+    }
+
+    [Test]
+    public void IconOffsetIsCopiedIntoMutableAppearances() {
+        MutableAppearance appearance = MutableAppearance.Get();
+        try {
+            appearance.IconOffset = new Vector2i(4, 7);
+
+            var immutable = new ImmutableAppearance(appearance, null);
+            MutableAppearance copy = immutable.ToMutable();
+
+            try {
+                Assert.That(copy.IconOffset, Is.EqualTo(new Vector2i(4, 7)));
+            } finally {
+                copy.Dispose();
+            }
+        } finally {
+            appearance.Dispose();
+        }
+    }
+}

Content.Tests/BrowserBridgeTests.cs

@@ -0,0 +1,55 @@
+using NUnit.Framework;
+using OpenDreamClient.Interface;
+using OpenDreamShared.Interface.DMF;
+
+namespace Content.Tests;
+
+[TestFixture]
+public sealed class BrowserBridgeTests {
+    [Test]
+    public void WildcardWingetJsonUsesRawStringValues() {
+        var json = BrowserBridgeJson.EncodePropertyMap([
+            ("size", new DMFPropertySize(640, 456)),
+            ("pos", new DMFPropertyPos(12, 34))
+        ], rawStringValues: true);
+
+        Assert.Multiple(() => {
+            Assert.That(json, Does.Contain("\"size\":\"640x456\""));
+            Assert.That(json, Does.Contain("\"pos\":\"12,34\""));
+            Assert.That(json, Does.Not.Contain("\"size\":{\"x\""));
+            Assert.That(json, Does.Not.Contain("\"pos\":{\"x\""));
+        });
+    }
+
+    [Test]
+    public void ExplicitJsonWingetKeepsTypedValues() {
+        var json = BrowserBridgeJson.EncodePropertyMap([
+            ("size", new DMFPropertySize(640, 456)),
+            ("pos", new DMFPropertyPos(12, 34))
+        ], rawStringValues: false);
+
+        Assert.Multiple(() => {
+            Assert.That(json, Does.Contain("\"size\":{\"x\":640"));
+            Assert.That(json, Does.Contain("\"y\":456"));
+            Assert.That(json, Does.Contain("\"pos\":{\"x\":12"));
+            Assert.That(json, Does.Contain("\"y\":34"));
+        });
+    }
+
+    [Test]
+    public void TguiOutputMessageBecomesBrowserUpdateCall() {
+        const string message = "%7b%22type%22%3a%22props%22%2c%22payload%22%3a%7b%22size%22%3a%22640x456%22%7d%7d";
+
+        var script = BrowserBridgeScript.FormatOutputCall("update", message);
+
+        Assert.That(script, Is.EqualTo("update(\"{\\\"type\\\":\\\"props\\\",\\\"payload\\\":{\\\"size\\\":\\\"640x456\\\"}}\")"));
+    }
+
+    [Test]
+    public void OutputParamsBecomeSeparateBrowserArguments() {
+        var arguments = BrowserBridgeScript.FormatOutputArguments("first%20arg&second%22arg");
+
+        Assert.That(arguments, Is.EqualTo("\"first arg\",\"second\\\"arg\""));
+    }
+
+}

Content.Tests/DMProject/Tests/Animation/animate_null_object.dm

@@ -0,0 +1,9 @@
+// NOBYOND - OpenDream-specific animate(null) compatibility smoke test
+/proc/RunTest()
+	ASSERT(isnull(animate(null)))
+	ASSERT(isnull(animate(null, alpha = 128, time = 1)))
+	ASSERT(isnull(animate(alpha = 128, time = 1)))
+
+	var/obj/O = new()
+	animate(O, pixel_x = 8, time = 1)
+	animate(pixel_y = 4, time = 1)

Content.Tests/DMProject/Tests/Appearance/OverlaySourceRefcount.dm

@@ -0,0 +1,25 @@
+// NOBYOND - OpenDream refcount regression test
+/proc/RunTest()
+	world.maxx = 1
+	world.maxy = 1
+	world.maxz = 1
+
+	var/obj/owner = new(locate(1, 1, 1))
+	var/obj/source = new(locate(1, 1, 1))
+	var/baseline = refcount(source)
+
+	owner.overlays += source
+	var/after_add = refcount(source)
+	if (after_add != baseline + 1)
+		CRASH("Expected overlays += source to hold one source ref; baseline [baseline], got [after_add]")
+
+	owner.overlays.Cut()
+	ASSERT(refcount(source) == baseline)
+
+	owner.overlays = list(source)
+	var/after_replace = refcount(source)
+	if (after_replace != baseline + 1)
+		CRASH("Expected overlays = list(source) to hold one source ref; baseline [baseline], got [after_replace]")
+
+	owner.overlays -= source
+	ASSERT(refcount(source) == baseline)

Content.Tests/DMProject/Tests/Appearance/mutable_appearance_underlay_remove.dm

@@ -0,0 +1,14 @@
+/proc/RunTest()
+	var/atom/A = new /obj()
+	var/mutable_appearance/underlay = new /mutable_appearance()
+	underlay.plane = 1
+	A.underlays += underlay
+
+	var/mutable_appearance/copy = new(A)
+	copy.plane = 2
+
+	for (var/mutable_appearance/current as anything in copy.underlays)
+		if (current.plane != copy.plane)
+			copy.underlays -= current
+
+	ASSERT(length(copy.underlays) == 0)

Content.Tests/DMProject/Tests/Area/contents_assignment.dm

@@ -0,0 +1,16 @@
+/area/contents_assignment
+
+/proc/RunTest()
+	world.maxx = 1
+	world.maxy = 1
+	world.maxz = 1
+
+	var/turf/turf = locate(1, 1, 1)
+	var/area/old_area = turf.loc
+	var/area/contents_assignment/new_area = new
+
+	new_area.contents = list(turf)
+
+	ASSERT(turf.loc == new_area)
+	ASSERT(turf in new_area.contents)
+	ASSERT(!(turf in old_area.contents))

Content.Tests/DMProject/Tests/Atom/color_default.dm

@@ -0,0 +1,7 @@
+/proc/RunTest()
+	var/atom/A = new /obj()
+	ASSERT(isnull(A.color))
+	ASSERT(isnull(initial(A.color)))
+
+	A.color = "#ff0000"
+	ASSERT(A.color == "#ff0000")

Content.Tests/DMProject/Tests/Atom/empty_icon_state_is_null.dm

@@ -0,0 +1,16 @@
+// NOBYOND - OpenDream normalizes empty appearance icon_state values to null
+/obj/empty_icon_state
+	icon_state = ""
+
+/proc/RunTest()
+	var/obj/empty_icon_state/type_path = /obj/empty_icon_state
+	var/obj/empty_icon_state/instance = new
+
+	ASSERT(isnull(initial(type_path.icon_state)))
+	ASSERT(isnull(instance.icon_state))
+
+	instance.icon_state = "filled"
+	ASSERT(instance.icon_state == "filled")
+
+	instance.icon_state = ""
+	ASSERT(isnull(instance.icon_state))

Content.Tests/DMProject/Tests/Atom/icon_state_default.dm

@@ -0,0 +1,6 @@
+/proc/RunTest()
+	var/atom/A = /atom
+	var/obj/O = /obj
+
+	ASSERT(isnull(initial(A.icon_state)))
+	ASSERT(isnull(initial(O.icon_state)))

Content.Tests/DMProject/Tests/Atom/implicit_parent_appearance_vars.dm

@@ -0,0 +1,16 @@
+/obj/implicit_parent_appearance/child
+	icon_state = "child"
+
+/proc/RunTest()
+	var/obj/implicit_parent_appearance/parent_type = /obj/implicit_parent_appearance
+	var/obj/implicit_parent_appearance/child/child_type = /obj/implicit_parent_appearance/child
+
+	ASSERT(isnull(initial(parent_type.icon_state)))
+	ASSERT(initial(child_type.icon_state) == "child")
+
+	for(var/obj/obj_path as anything in typesof(/obj/implicit_parent_appearance) - /obj/implicit_parent_appearance)
+		if(obj_path == /obj/implicit_parent_appearance/child)
+			ASSERT(initial(obj_path.icon_state) == "child")
+			continue
+
+		ASSERT(isnull(initial(obj_path.icon_state)))

Content.Tests/DMProject/Tests/Builtins/JsonDecodeStringArray.dm

@@ -0,0 +1,7 @@
+/proc/RunTest()
+	var/list/decoded = json_decode(@'["alpha","beta"]')
+
+	ASSERT(decoded[1] == "alpha")
+	ASSERT(decoded[2] == "beta")
+	ASSERT(isnull(decoded["alpha"]))
+	ASSERT(isnull(decoded["beta"]))

Content.Tests/DMProject/Tests/Builtins/Replacetext.dm

@@ -40,3 +40,10 @@
 	// /regex can be used as a Needle
 	ASSERT(replacetext(str, new /regex("."), "G") == "GBCDEF");
 	ASSERT(replacetext(str, new /regex(".", "g"), "G") == "GGGGGG");
+
+	var/lizard_speech = "She is so sassy"
+	lizard_speech = replacetextEx(lizard_speech, new /regex("s+", "g"), "sss")
+	lizard_speech = replacetextEx(lizard_speech, new /regex("S+", "g"), "SSS")
+	ASSERT(lizard_speech == "SSShe isss ssso sssasssy")
+
+	ASSERT(replacetextEx("X-ray X box", new /regex(@"\bX([\-|r|R]|\b)", "g"), "ECKS$1") == "ECKS-ray ECKS box")

Content.Tests/DMProject/Tests/Builtins/callee.dm

@@ -5,14 +5,24 @@
 	ASSERT(callee.desc == "bar description")
 	return callee
 
+/proc/leaf()
+	ASSERT(callee.name == "leaf")
+	ASSERT(caller.name == "middle")
+
+/proc/middle()
+	ASSERT(caller.name == "RunTest")
+	leaf()
+
 /proc/RunTest()
 	ASSERT(callee.name == "RunTest")
 	ASSERT(copytext(callee.file, -9) == "callee.dm")
+
+	middle()
 
 	var/callee/expired_callee = bar()
 	var/failed = FALSE
 	try
 		var/name = expired_callee.name
 	catch (var/exception/E)
 		failed = TRUE
-	ASSERT(failed)
+	ASSERT(failed)

Content.Tests/DMProject/Tests/Builtins/deleted_object_null.dm

@@ -0,0 +1,6 @@
+/proc/RunTest()
+	var/datum/thing = new()
+	del(thing)
+
+	ASSERT(isnull(thing))
+	ASSERT("[thing]" == "")

Content.Tests/DMProject/Tests/Builtins/filter_color_default.dm

@@ -0,0 +1,5 @@
+/proc/RunTest()
+	var/atom/movable/A = new /obj()
+
+	A.filters += filter(type = "color")
+	ASSERT(length(A.filters) == 1)

Content.Tests/DMProject/Tests/Builtins/get_step_deleted.dm

@@ -0,0 +1,6 @@
+/proc/RunTest()
+	var/obj/item = new /obj()
+	del(item)
+
+	ASSERT(isnull(get_step(item, NORTH)))
+	ASSERT(isnull(get_step(item, 0)))

Content.Tests/DMProject/Tests/Builtins/icon_states_modes.dm

@@ -0,0 +1,7 @@
+/proc/RunTest()
+	var/list/default_states = icon_states('turf.dmi')
+	ASSERT(length(default_states))
+	ASSERT(!("" in default_states))
+
+	ASSERT(length(icon_states('turf.dmi', 1)) == length(default_states))
+	ASSERT(length(icon_states('turf.dmi', 2)) == length(default_states))

Content.Tests/DMProject/Tests/Builtins/ispath_dynamic_path.dm

@@ -0,0 +1,9 @@
+/obj/ispath_dynamic_parent
+
+/obj/ispath_dynamic_parent/child
+
+/proc/RunTest()
+	var/list/allowed = list(/obj/ispath_dynamic_parent)
+	var/type = allowed[1]
+
+	ASSERT(ispath(/obj/ispath_dynamic_parent/child, type))

Content.Tests/DMProject/Tests/Builtins/istype_dynamic_path.dm

@@ -0,0 +1,10 @@
+/obj/istype_dynamic_parent
+
+/obj/istype_dynamic_parent/child
+
+/proc/RunTest()
+	var/obj/O = new /obj/istype_dynamic_parent/child
+	var/list/allowed = list(/obj/istype_dynamic_parent)
+	var/type = allowed[1]
+
+	ASSERT(istype(O, type))