Skip to content

Conversation

@rriedl
Copy link

@rriedl rriedl commented Jul 22, 2015

@catrobatjenkins
Copy link
Contributor

Can a catrobat member please verify this patch? If it doesn't look evil comment with "ok to test" to start the testrun.

@avihric avihric added the Hotfix label Jul 22, 2015
@thmq
Copy link
Contributor

thmq commented Jul 23, 2015

Seems all right, you should only look into the two failing test cases [1]. In order to do so you might want to start a single package test on Jenkins.

[1] https://jenkins.catrob.at/job/Catroid-ParalellEmulatorUITest-CustomBranch/2140/

@rriedl rriedl force-pushed the CAT-1443_SetChangeVariable branch from 90768d1 to 1619e38 Compare August 6, 2015 13:21
@rriedl
Copy link
Author

rriedl commented Aug 6, 2015

@robertpainsi
Copy link
Member

Please rebase your branch and afterwards run the gradle checkstyle task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unnecessary.

@avihric
Copy link
Contributor

avihric commented Aug 7, 2015

Please remove the blank lines between the solo commands and add blank lines before and after asserts in ChangeVariableTest.java & SetVariableTest.java

@avihric
Copy link
Contributor

avihric commented Aug 8, 2015

rerun: Jenkins

avihric added a commit that referenced this pull request Aug 8, 2015
@avihric avihric merged commit e33035b into Catrobat:master Aug 8, 2015
@avihric
Copy link
Contributor

avihric commented Aug 8, 2015

Merged for same reason as #1325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants