Conversation
|
Why do we have so many new dependencies? I was talking about |
I removed all the extra packages i used and now i am only using jspdf and html2canvas. |
|
Okay, that makes sense, thanks for clarifying. Let me see if I can fix the conflicts... |
src/components/Rezume/Rezume.js
Outdated
| //function for download as png | ||
| const downloadAsPNG =()=>{ | ||
| const rezumeContainer = document.getElementById('rezume'); | ||
| html2canvas(rezumeContainer).then(function(canvas) { | ||
| var link = document.createElement("a"); | ||
| document.body.appendChild(link); | ||
| link.download = "rezume.png"; | ||
| link.href = canvas.toDataURL("image/png"); | ||
| link.target = '_blank'; | ||
| link.click(); | ||
| }) | ||
| } |
There was a problem hiding this comment.
For the whole file, please kindly indent the content in 2 space mode.
praveenscience
left a comment
praveenscience
left a comment
There was a problem hiding this comment.
Can you use the prettier settings? 😁
|
No wait. Lemme check and try helping out with the conflict resolution... |
|
Hey... Can you try cherry-picking and fixing it? |
| const downloadAsPNG = () => { | ||
| const rezumeContainer = document.getElementById("rezume"); | ||
| html2canvas(rezumeContainer).then(function (canvas) { | ||
| var link = document.createElement("a"); | ||
| document.body.appendChild(link); | ||
| link.download = "rezume.png"; | ||
| link.href = canvas.toDataURL("image/png"); | ||
| link.target = "_blank"; | ||
| link.click(); | ||
| }); | ||
| }; | ||
| //function for download as jpeg | ||
| const downloadAsJpeg = () => { | ||
| const rezumeContainer = document.getElementById("rezume"); | ||
| html2canvas(rezumeContainer).then(function (canvas) { | ||
| var link = document.createElement("a"); | ||
| document.body.appendChild(link); | ||
| link.download = "rezume.jpeg"; | ||
| link.href = canvas.toDataURL("image/jpeg"); | ||
| link.target = "_blank"; | ||
| link.click(); | ||
| }); | ||
| }; |
There was a problem hiding this comment.
We don't need these two anyway. We can remove it.
| {Summary} | ||
| </p> | ||
| </div> | ||
| <div className="py-5 download-btns"> |
There was a problem hiding this comment.
Just wondering if we can keep the download button on the navbar?
There was a problem hiding this comment.
This issue has been stale for many days now, any update on the progress would be appreciated @Neha9849
3 participants
Issue that this pull request solves
Closes: #86
Proposed changes
I added 3 buttons - Download as png, Download as jpeg and Download as pdf
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request