Skip to content

Conversation

@Beilinson
Copy link
Contributor

@Beilinson Beilinson commented Nov 27, 2025

Some of the tests in Cesium3DTilesetSpec.js have consistently been failing for a long time already due to a default timeout of 5s, this PR provides a simple fix by increasing the default jasmine timeout to 10s for each of the tests in this suite exclusively, and then resetting it to the original default.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@github-actions
Copy link

Thank you for the pull request, @Beilinson!

✅ We can confirm we have a CLA on file for you.

@Beilinson
Copy link
Contributor Author

Beilinson commented Nov 27, 2025

example runs from #12630 and #12974 with this error:

image

@javagl
Copy link
Contributor

javagl commented Nov 28, 2025

This has been ""tracked"" in #12823 and #11446 (note: one is closed, the other one open), with several PRs associated with them where this happened or was supposed to be fixed. We considered that it might be a race condition (e.g. in this issue, but also that it might just be a test that sometimes takes 4999ms and sometimes 5001ms.

(I also saw that failure occasionally, but ... who knows what's really happening there...? ... so just shrugged it off and restarted the test....)

When you say that increasing the timeout fixes it, then ... I'm a bit surprised: What is actually taking 5 seconds there? And... of course, it's nearly impossible to verify that this consistently fixes the issue. But even if it only causes the issue to come up less frequently, that could be worth merging.

@Beilinson
Copy link
Contributor Author

Agreed that its difficult to verify that this even is the problem, thing is I never have encountered this test failing on either my personal laptop or pc from a timeout, meanwhile it fails on at least half of the PR CI runs I've submitted, leading me to think its genuinely a slightly slow test suite that fails sometimes in CI. I did try debugging the test locally and couldn't see anything that would cause this test to fail as often as it does in CI.

#11446 I see that @ggetz also suggested increasing the timeout in the poller, so I added that as well just in case

@Beilinson
Copy link
Contributor Author

Beilinson commented Nov 28, 2025

I dont think will fix all of the issues with that suite however, for example https://github.com/CesiumGS/cesium/actions/runs/19678965074/job/56367761968 this run has a different test failing with Unhandled promise rejection: undefined thrown (same as #11958 (comment) that you mentioned)

@Beilinson
Copy link
Contributor Author

I think its worth it to merge just because this issue only appears in CI, if it goes away then great if not then this can be reverted and back to the drawing board 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants