Skip to content

Attempt at making the thread feature work on 5.3.2, and a fix that at…#2

Open
dantarion wants to merge 1 commit into
Chadderz121:masterfrom
dantarion:master
Open

Attempt at making the thread feature work on 5.3.2, and a fix that at…#2
dantarion wants to merge 1 commit into
Chadderz121:masterfrom
dantarion:master

Conversation

@dantarion
Copy link
Copy Markdown

… least lets it run on things that aren't 4.1.0

http://i.imgur.com/cWLtgFH.png Does this look right?

… least lets it run on things that aren't 4.1.0

http://i.imgur.com/cWLtgFH.png Does this look right?
@Chadderz121
Copy link
Copy Markdown
Owner

Hmm, I think your change will miss some threads. Why did you move the first while loop into the 410 block?

I wonder if a better fix would be to replace the entire if (os_ver) statement with tempThreadAddress = gecko.peek(0xffffffe0). That should remain portable forever. I don't have a Wii U to test that fix though. You would also need to restore that first while loop so that the code would look something like:

uint tempThreadAddress = gecko.peek(0xffffffe0);
uint temp;
while ((temp = gecko.peek(tempThreadAddress + 0x390)) != 0)
{
    tempThreadAddress = temp;
}
while ((temp = gecko.peek(tempThreadAddress + 0x38C)) != 0)
{
    AddThread(tempThreadAddress);
    tempThreadAddress = temp;
}
// The above while is nice, but would skip the last thread.
AddThread(tempThreadAddress);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants