Skip to content

Propose shield fixes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 28, 2025
Merged

Propose shield fixes #107

merged 9 commits into from
Jul 28, 2025

Conversation

pacu
Copy link
Contributor

@pacu pacu commented Jul 3, 2025

Changes

  • use zcash_protocol's networkType and remove unused variable
  • change use of deprecated BalanceError in favor of zcash_protocol one
  • Use Zip32 crate instead of re-pub of librustzcash (same version)
  • remove usage of deprecated ShieldedProtocol in favor of zcash_protocol one
  • remove NonNegativeAmount use in favor of Zatoshis
  • Use shielding threshold as Zashi and Mobile SDKs do

Tests

No tests altered.

Issues

#106
Closes #106

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2025

CLA assistant check
All committers have signed the CLA.

@irubido
Copy link
Collaborator

irubido commented Jul 28, 2025

Screenshot from 2025-07-28 14-12-37 added UI, button disables below 0.001 ZEC

@irubido irubido merged commit 98a1237 into ChainSafe:main Jul 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposed shielding should use a threshold above MARGINAL_FEE
3 participants