Skip to content

Propose shield fixes #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Propose shield fixes #107

wants to merge 6 commits into from

Conversation

pacu
Copy link

@pacu pacu commented Jul 3, 2025

Changes

  • use zcash_protocol's networkType and remove unused variable
  • change use of deprecated BalanceError in favor of zcash_protocol one
  • Use Zip32 crate instead of re-pub of librustzcash (same version)
  • remove usage of deprecated ShieldedProtocol in favor of zcash_protocol one
  • remove NonNegativeAmount use in favor of Zatoshis
  • Use shielding threshold as Zashi and Mobile SDKs do

Tests

No tests altered.

Issues

#106

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pacu pacu mentioned this pull request Jul 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pacu @CLAassistant