-
Notifications
You must be signed in to change notification settings - Fork 352
feat(query): implements "Beta - SQL DB Instance With Limited User Connections" #7788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): implements "Beta - SQL DB Instance With Limited User Connections" #7788
Conversation
…ns'_flag_is_set_to_non_limiting_value
…16632_19_6.3.3_ensure_'user_Connections'_flag_is_set_to_non_limiting_value
cx-artur-ribeiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey André, can you check my comment please?
assets/queries/terraform/gcp/sql_db_instance_with_limited_user_connections/metadata.json
Outdated
Show resolved
Hide resolved
…ns'_flag_is_set_to_non_limiting_value
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 21271469 | Triggered | Generic Password | badc40a | assets/queries/terraform/azure/unrestricted_sql_server_access/test/negative4.tf | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.








Reason for Proposed Changes
Currently there is no query to ensure that a "google_sql_database_instance" resource with a "SQLSERVER" based "database_version" has the 'user connections' flag set to
0.Quoting CIS_Google_Cloud_Platform_Foundation_Benchmark_v4.0.0 page 250: "
The user connections option specifies the maximum number of simultaneous user connections that are allowed on an instance of SQL Server....SQL Server allows a maximum of 32,767 user connections. Because user connections is by default a self-configuring value, with SQL Server adjusting the maximum number of user connections automatically as needed, up to the maximum value allowable....The default is 0, which means that the maximum (32,767) user connections are allowed. However if there is a number defined here that limits connections, SQL Server will not allow anymore above this limit. If the connections are at the limit, any new requests will be dropped, potentially causing lost data or outages for those using the database.Proposed Changes
Tenable reference
I submit this contribution under the Apache-2.0 license.