forked from TEN-framework/ten-framework
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Add Nova Sonic v2 parameter support and voice type mapping verification #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chen188
wants to merge
33
commits into
main
Choose a base branch
from
setup-development-20251217-100424
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to display chat in playground; other code improvements.
* new: add translation mode in playground * update: add more languages in playground
* using partial result to reduce wait time for translation mode
allow using LLMs hosting on Amazon SageMaker.
Set `Chat` mode as default
refactor: move settings into a dialog component feat: add info and description popups in header feat: integrate system prompt configuration style: simplify home page layout
Add Bedrock MCP Python extension and related UI components: * Create bedrock_mcp_python extension with implementation files * Add MCP settings UI components in playground * Implement server-side HTTP client for MCP communication * Update configuration files for MCP integration * Modify ConnectButton and SettingsDialog for MCP support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概述 (Overview)
本 PR 增强了 Amazon Nova Sonic v2 的支持,确保前端正确传递所有必需参数到后端,并验证了语音类型映射配置的完整性。
This PR enhances Amazon Nova Sonic v2 support by ensuring all required parameters are correctly passed from frontend to backend and verifying voice type mapping configuration completeness.
实现的需求 (Requirements Implemented)
前端更改 (Frontend Changes)
✅ 在
playground/src/components/header/ConnectButton/index.tsx中修复参数传递:novaSonicWsUrl: novaSonicWsUrl参数传递(第115行)turnTakingPauseSensitivity: turnTakingPauseSensitivity参数传递(第116行)voiceType: voice参数正确传递(第104行)后端更改 (Backend Changes)
✅ 在
server/internal/config.go中验证语音映射:voiceNameMap正确包含 male 和 female 的映射关系(第204-241行)✅ 在
server/internal/http_server.go中验证字段定义:VoiceType字段正确定义和处理(第57行)TurnTakingPauseSensitivity字段正确定义和处理(第67行)NovaSonicWsUrl字段正确定义和处理(第66行)技术细节 (Technical Details)
参数流程 (Parameter Flow)
ConnectButton组件通过apiStartService将参数传递给后端http_server.go中的请求结构体接收并验证参数config.go中的voiceNameMap将抽象的语音类型(male/female)映射到具体的语音标识关键改进 (Key Improvements)
验证方法 (Verification Methods)
前端验证 (Frontend Verification)
后端验证 (Backend Verification)
测试建议 (Testing Recommendations)
turnTakingPauseSensitivity值对对话体验的影响影响范围 (Impact Scope)
相关文件 (Related Files)
playground/src/components/header/ConnectButton/index.tsxserver/internal/config.goserver/internal/http_server.goplayground/DockerfileDockerfile注意:本 PR 专注于参数传递和配置验证,确保 Amazon Nova Sonic v2 集成的完整性和可配置性。