[Feature] Modify navbar completed #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nan0ck
suggested changes
Feb 21, 2025
CryptoHackAI-web/package-lock.json
Outdated
Contributor
There was a problem hiding this comment.
Hey! can we remove from the PR the package-lock.json and the yarn.lock update? I dont see those being relevant to the UI updates
Contributor
Author
There was a problem hiding this comment.
Sure, give me a second
Contributor
Author
There was a problem hiding this comment.
Btw, this files do not affect the UI, but could possibly affect the dependencies definition of the project. Just for you to keep in mind
Contributor
There was a problem hiding this comment.
agree, no need to add them to the gitignore tho, I was refering to removing the updates from the PR
Nan0ck
reviewed
Feb 21, 2025
| className="mr-2 hover:scale-105 transition-transform" | ||
| /> | ||
| <Link href="/" className="text-3xl font-bold tracking-wide">Crypto AI</Link> | ||
| {/* <Link href="/" className="text-3xl font-bold tracking-wide">Crypto AI</Link> */} |
Contributor
There was a problem hiding this comment.
let's remove the commented line to keep everything clean
Contributor
Author
|
I just updated the state of the PR, please check if you need me to do something else |
Nan0ck
approved these changes
Feb 21, 2025
Ilialtes
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
With this PR I modified the style of the navbar to fit the figma design. I think the white background is a style for the active link, so for this I used a dynamic definition and load of links and then set the style for active and non-active.
Also for the login link, I don't know if the login page will remain, but I associate the "connect" button with this page.