feat(contract): add cancellation window constraints#105
Merged
Conversation
|
@lycantho Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@thlpkee20-wq please merge |
Author
1 similar comment
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SC-020] Add Cancellation Window Constraints
Description
This PR addresses issue #20 by implementing cancellation window constraints for time slot tokens in the ChronoPay smart contract, ensuring buyers are prevented from cancelling a time slot too close to the start time.
Core Changes
CancelWindowSecs,SlotBuyer(u32), andSlotStartTime(u32)to keep track of slot configuration, buyer records, and scheduled start times.buy_time_slot: A robust handler complementing the old stub, registering the buyer for a slot.set_cancel_window: Allows the contract owner to configure the allowed cancellation window prior to start time (defaulting to 3600 seconds/1 hour).cancel_time_slot: Enables a buyer to cancel their reservation if requested before the designated cancellation window starts. If called too late, or for non-existent/unsold slots, the transaction panics. Safely resets the slot status toAvailableupon success.Testing
panic!conditions (e.g., zero windows, cancelling post-deadline, cancelling unassigned slots).Security and Architecture Notes
Closes #20.