feat(contract): add input length limits for strings#106
Merged
Conversation
|
@lycantho Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@thlpkee20-wq please merged and assign me to two more, I am active sir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SC-034] Add Input Length Limits For Strings
Description
This PR addresses issue #34 by implementing maximum length validations for all
Stringparameters across the ChronoPay smart contract entrypoints. Setting an upper bounds on strings prevents unrestrained memory allocations and excessive gas consumption on Soroban, making the contract highly secure and optimized.Core Changes (Scope:
contracts/chronopay/src/lib.rs)validate_string_max_lenhelper: An internal function checkings.len() > limitand safely panicking with"string_too_long"dynamically.64characters to:professionalinput increate_time_slotbuyerandsellerinputs inbuy_time_tokentoinput inhellosanity method.Testing (Scope:
contracts/chronopay/src/test.rs)create_long_stringhelper that artificially manufactures length 65 character strings for injection testing.test_long_professional_panicstest_long_buyer_panicstest_long_seller_panicstest_long_hello_panicsSecurity Notes
Closes #34.