Feature/sc 029#111
Merged
Merged
Conversation
|
@Arowolokehinde Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes #29
Implemented a secure, two-step admin role rotation mechanism (propose_admin and accept_admin) in the ChronoPay contract to prevent accidental lockouts caused by transferring roles to unverified addresses.
Implementation & Security Notes
Clean Architecture & O(1) Complexity: Uses Soroban's native Instance storage getter/setters for constant-time lookups without redundancy.
Two-Step Verification: Requires the current admin to propose a new address via propose_admin, which must subsequently be claimed securely via accept_admin using the new administrator’s signature.
Strict Authorization: Validates permissions using Address::require_auth() to leverage the Soroban host environment's native cryptographic constraints for tamper-resistance.
Testing & Acceptance Criteria
Passed full test suite (30/30 tests ok, 0.09s).
Validated edge cases: Rejecting un-authorized callers, preventing the admin from proposing themselves, and ensuring nobody except the proposed admin can accept the role.
Minimum 95% test coverage threshold met for modified chronopay/src modules.