feat(contract): [SC-009] Prevent Double Minting Per Slot#117
Merged
Conversation
|
@KayProject Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements SC-009 — prevents any slot from being minted more than once in the ChronoPay contract.
Changes
Added
Minted(u32)variant toDataKeyenum to track minted slotsUpdated
mint_time_tokento check storage before minting and panic with"slot already minted"if the slot has already been mintedAdded
test_prevent_double_mint_same_slottest using#[should_panic]to verify the guard worksSecurity Notes
Guard uses instance storage — same ledger scope as all other contract state
Panic is deterministic and immediate — no partial state is written on double-mint attempt
Slot ID is scoped per
u32key — no cross-slot interferenceTest Coverage
Existing tests (
test_hello,test_create_time_slot_auto_increments,test_mint_and_redeem) unchanged and unaffectedNew test confirms second mint on same slot reverts as expected
Closes #9