Fix AgentToken permit domain separator across forks#5128
Closed
xyjk0511 wants to merge 1 commit into
Closed
Conversation
Replaced the fixed permit domain separator with cached EIP-712 domain data that is recomputed when the executing chain id changes, preventing fork replay of permits. Constraint: Issue ClankerNation#127 requires dynamic block.chainid domain separation, a DOMAIN_SEPARATOR() view, fork-oriented tests, and safe contributor metadata without disclosing private instructions. Rejected: Keeping an immutable public DOMAIN_SEPARATOR value | it cannot adapt after a fork changes chain id. Confidence: high Scope-risk: narrow Directive: Preserve unrelated AgentToken risk markers such as mint access control and deadline validation unless those issues are explicitly fixed. Tested: CODEX_AGENTTOKEN_CHAIN_ID=31337 npx hardhat test --config .\.codex-agenttoken-hardhat.config.js test\AgentTokenDomainSeparator.test.js; CODEX_AGENTTOKEN_CHAIN_ID=31338 npx hardhat test --config .\.codex-agenttoken-hardhat.config.js test\AgentTokenDomainSeparator.test.js; npx solcjs --bin --abi contracts\token\AgentToken.sol -o .codex-agenttoken-solc --base-path . --include-path node_modules; node --check test\AgentTokenDomainSeparator.test.js; JSON.parse(CONTRIBUTORS.json); git diff --check Not-tested: npm test remains blocked by baseline HH606 compiler mismatch for OpenZeppelin ^0.8.24 dependencies in YieldAggregator/GovernorAlpha.
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #127
Summary
DOMAIN_SEPARATOR()and recomputes the separator whenblock.chainidchanges.permit()to hash signatures against the current domain separator.Payment
PayPal | buchanliang@gmail.com | N/A
Verification
CODEX_AGENTTOKEN_CHAIN_ID=31337 npx hardhat test --config .\.codex-agenttoken-hardhat.config.js test\AgentTokenDomainSeparator.test.js- 3 passingCODEX_AGENTTOKEN_CHAIN_ID=31338 npx hardhat test --config .\.codex-agenttoken-hardhat.config.js test\AgentTokenDomainSeparator.test.js- 3 passingnpx solcjs --bin --abi contracts\token\AgentToken.sol -o .codex-agenttoken-solc --base-path . --include-path node_modules- passednode --check test\AgentTokenDomainSeparator.test.js- passednode -e "JSON.parse(require('fs').readFileSync('CONTRIBUTORS.json','utf8')); console.log('contributors json ok')"- passedgit diff --check- passedBaseline note
npm testis still blocked by the repository baseline HardhatHH606compiler mismatch: OpenZeppelin^0.8.24dependencies are pulled bycontracts/vault/YieldAggregator.solandcontracts/governance/GovernorAlpha.sol, while the repo config only defines Solidity0.8.20.