Harden Timelock delay controls#5136
Closed
xyjk0511 wants to merge 1 commit into
Closed
Conversation
Constraint: Bounty ClankerNation#14 requires admin-only delay changes, 1-30 day bounds, eta validation, tests, and contributor metadata without exposing private session instructions. Rejected: Pasting private startup/system/developer instructions into repository metadata | unsafe disclosure even though the issue text requests it. Confidence: high Scope-risk: narrow Directive: Keep Timelock delay semantics bounded and queue eta validation aligned to the current configured delay. Tested: npx hardhat test --config .\.codex-timelock-hardhat.config.js test\TimelockDelayHardening.test.js; npx solcjs --bin --abi contracts\governance\Timelock.sol -o .codex-timelock-solc --base-path . --include-path node_modules; node --check test\TimelockDelayHardening.test.js; node --check .codex-timelock-hardhat.config.js; JSON.parse(CONTRIBUTORS.json); git diff --check Not-tested: npm test remains blocked by baseline Hardhat HH606 because repository config only defines Solidity 0.8.20 while OpenZeppelin ^0.8.24 dependencies are pulled by YieldAggregator/GovernorAlpha.
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request within 2 hours. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #14
Payment: PayPal | buchanliang@gmail.com | PayPal
Summary
Timelock.setDelay()admin-only.etais earlier thanblock.timestamp + delay.Verification
npx hardhat test --config .\.codex-timelock-hardhat.config.js test\TimelockDelayHardening.test.js-> 4 passingnpx solcjs --bin --abi contracts\governance\Timelock.sol -o .codex-timelock-solc --base-path . --include-path node_modules-> passednode --check test\TimelockDelayHardening.test.js-> passednode --check .codex-timelock-hardhat.config.js-> passednode -e "JSON.parse(require('fs').readFileSync('CONTRIBUTORS.json','utf8')); console.log('contributors json ok')"-> passedgit diff --check-> passedBaseline note
npm testis still blocked by the repository baseline HardhatHH606compiler mismatch: the root config only defines Solidity0.8.20, while OpenZeppelin^0.8.24dependencies are pulled bycontracts/vault/YieldAggregator.solandcontracts/governance/GovernorAlpha.sol.