fix(cli): remove duplicate shebang causing Self-Scan Skills failure#4
Merged
Conversation
tsup config injects shebang via banner for ESM output. Having the shebang in source caused dist/cli.js to have two consecutive shebang lines, where the second was parsed as a syntax error when node executed the file (Self-Scan Skills CI failure). Verified: head -3 dist/cli.js post-rebuild shows single shebang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
apps/cli/src/cli.tshad#!/usr/bin/env nodeon line 1, ANDapps/cli/tsup.config.tsinjects the shebang viabannerfor ESM output. Result:dist/cli.jsstarted with two consecutive#!/usr/bin/env nodelines. Node executes the first as the interpreter directive, then parses the second as JS — syntax error.This broke the
Self-Scan SkillsCI job which runsnode apps/cli/dist/cli.js scan ...after build.Fix
Replaced the source shebang with a comment. tsup banner remains the single source of truth for the ESM shebang.
Verification
CJS output (
dist/cli.cjs) unaffected — banner is ESM-only, and source shebang was previously being bundled into CJS as garbage too (now also clean).Note
Pre-existing lint warnings re: moduleResolution are unrelated to this PR.