-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release ct v6.2.0 #590
Merged
Merged
Release ct v6.2.0 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deleted the module and files
- workflows related to xps
- no ref to xiaomi or any of its functionalities anymore - removed code from sample app - removed code from main CleverTapApi facade
- fixed init of variables in class first before using them in deviceInfo
- did not use device id from state variable (shared pref map) - instead passed device id back from func as it is created on fly - this reduces risk of state variable changing over time as it is accessed in future
- simplified ternary as it would always return null in both cases
- the device id passed as method return type to be used - did not fetch device id from state (shared pref map)
- comment fixed - seems some unreachable code can be due to legacy
Bug/sdk 3671
* Port DatabaseHelper and DBAdapter to Kotlin * Port DBManager to Kotlin Update tests of DBManager and DBAdapter Rename QueueCursor to QueueData Port BaseDatabaseManager to Kotlin * Add mockito-kotlin to tests Change usage of ArgumentCaptor with DBAdapter to use mockito-kotlin * Never close the connection to the db once opened --------- Co-authored-by: CTLalit <[email protected]>
…into xiaomi_sunsetting # Conflicts: # clevertap-core/src/main/java/com/clevertap/android/sdk/CleverTapAPI.java # clevertap-xps/build.gradle # clevertap-xps/src/main/AndroidManifest.xml # clevertap-xps/src/main/java/com/clevertap/android/xps/CTXiaomiMessageHandler.java # docs/CTXIAOMIPUSH.md # gradle/libs.versions.toml # sample/build.gradle # templates/CTXIAOMIPUSH.md
- removed unreachable code and class
Xiaomi sunsetting
* fix(ANR) - add threading annotation for ease of understanding like which method must run on which thread SDK-3717 * fix(ANR) - add CtApiWrapper class to lazily initialize CtApi. Eager initialization of CtApi is causing ANR during CleverTapAPI instance creation triggered by DeviceId generation callback SDK-3717 * fix(ANR) - add AnrWatchDog to sample app SDK-3717 * fix(ANR) - remove unused cryptHandler from NetworkManager SDK-3717 * fix(ANR) - fix NetworkManager test SDK-3717 * fix(ANR) - add unit test for CtApiWrapper SDK-3717 * fix(ANR) - add documentation for CtApiWrapper SDK-3717 * fix(ANR) - remove isMainProcess check for xiaomi which is causing ANR SDK-3717 --------- Co-authored-by: CTLalit <[email protected]>
…bService from AndroidManifest.xml (#588) - These entries caused crashes in v6.1.0 and v6.1.1. Workaround was provided for client. It will now be fixed in the SDK itself
- upgrades ct sample app to add real time uninstall tracking - adds firebase analytics dependency
- added callback in case of cancel clicked in settings alert
CTLalit
approved these changes
Apr 3, 2024
* task(SDK-3743) - Release ctv6.2.0 - Updates CHANGELOG.md - Updates versions - Runs copyTemplates * task(SDK-3743) - Release ctv6.2.0 - Fixes a typo * task(SDK-3743) - Release ctv6.2.0 - Fixes a typo * task(SDK-3743) - Release ctv6.2.0 - Fixes a typo * task(SDK-3743) - Release ctv6.2.0 - Adds github issue link to changelog * task(SDK-3743) - Release ctv6.2.0 - Fixes typo * task(SDK-3743) - Release ctv6.2.0 - Changes crash to ANR * task(SDK-3743) - Release ctv6.2.0 - Moves new feature to bugfix
piyush-kukadiya
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 6.2.0 (April 3, 2024)
New Features
PromptForSettings
alert dialog..Bug Fixes
ClassNotFoundException
forCTBackgroundJobService
.NullPointerException
related todeviceInfo.deviceId
.NullPointerException
related toisMainProcess
check.CtApi
triggered by DeviceId generation.Breaking API Changes