feat(SDK-4030): IncorrectContextUseViolation #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
CTLalit
commented
Aug 30, 2024
CTLalit
commented
- uses version check and fixes windowmanager access from context
- removes redundant code for pixes which was unused
- uses version check and fixes windowmanager fetch - removes redundant code for pixes which was unused
- reduces service fetches from context - reduces version checks - refactors code to add placeholder class - returns window result as whole
Anush-Shand
reviewed
Sep 16, 2024
Anush-Shand
reviewed
Sep 16, 2024
clevertap-core/src/main/java/com/clevertap/android/sdk/DeviceInfo.java
Outdated
Show resolved
Hide resolved
- catches exception - removes decimal adjustment which was done twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.