-
Notifications
You must be signed in to change notification settings - Fork 27
rft: clean up precip cache computation #4103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
haakon-e
wants to merge
1
commit into
main
Choose a base branch
from
he/chore-clean-up-some-files
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6343795 to
d5fe42d
Compare
c087a6e to
f7d4b6f
Compare
d5fe42d to
2512576
Compare
f7d4b6f to
66c4dac
Compare
66c4dac to
a1e43c4
Compare
092ab4e to
c0af6f7
Compare
09aae22 to
3630586
Compare
c0af6f7 to
9405d3c
Compare
3630586 to
63bdc13
Compare
9405d3c to
a85a7a4
Compare
63bdc13 to
5fbc160
Compare
a85a7a4 to
0b16fd3
Compare
5fbc160 to
a020cb3
Compare
0b16fd3 to
32cc140
Compare
a020cb3 to
bde4417
Compare
9004d38 to
8f9cb8c
Compare
bde4417 to
8167c35
Compare
8167c35 to
09c6176
Compare
1d3e74f to
390a982
Compare
390a982 to
e70fbab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The treatment of various microphysical tracers is typically nearly identical. This pull request implements this abstraction by making extensive use of
ClimaCores@nameconstruct to refer to, and extract data related to, the various microphysical tracers likeq_liq,q_rai, etc.A few other significant features include:
ᶜwₛʲsand friends are not used at all anymore (though I haven't deleted the code that precomputes updraft sedimentation velocities just yet)More details below:
This pull request introduces several utility functions and refactors existing code to improve clarity and maintainability in microphysics and variable manipulation modules. The main focus is on adding helper functions for terminal velocities, tracer field name conversions, and subdomain density handling. It also includes minor refactoring and documentation improvements.
Microphysics utilities:
microphysics_wrappers.jlto select and compute terminal velocity functions for different microphysical schemes (1-moment and 2-moment), using the tracer name to dispatch the correct velocity calculation.Tracer and field name utilities:
variable_manipulations.jlto map between grid-scale tracer names and related field names, such asget_ᶜwᵪ_name_from_qᵪ_name,get_ᶜwₙᵪ_name_from_qᵪ_name, andget_nᵪ_name_from_qᵪ_name, each with clear documentation and examples.ᶜspecific_gs_tracerto lazily compute the specific tracer field from a grid-scale tracer name, and refactoredᶜspecific_gs_tracersto use this helper for improved clarity. [1] [2]Subdomain density handling:
ρa⁰) and for accessing subdomain densities, introducingᶜρaʲs_listandρaʲhelpers for both prognostic and diagnostic EDMFX models.General utilities and refactoring:
draft_sumto useunrolled_mapreducefor consistency and flexibility in summing over multiple subdomain states.WVecinabbreviations.jl.These changes collectively improve the modularity, readability, and extensibility of the codebase, particularly for microphysics and tracer field management.