Fix bg_gradient lh bug #4111
Open
Fix bg_gradient lh bug #4111
+22
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
reviewed
Nov 20, 2025
| get_qi_sat(thermo_params, bg_model) * | ||
| TD.latent_heat_sublim(thermo_params, t_sat) | ||
| ) / | ||
| (get_ql_sat(thermo_params, bg_model) + get_qi_sat(thermo_params, bg_model)) |
Member
There was a problem hiding this comment.
add an eps to make sure this is not divided by zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the latent heat bug discovered by @jbphyswx in our buoyancy gradients.
It would be great to rewrite parts of that file to get rid of the getter functions at the top and the bg_model, and to reduce the number of functions we define. But maybe we can do it in the next PRs.