Fix Jacobian-free Newton Krylov method on GPUs #2373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisYatunin
force-pushed
the
dy/jfnk_bugfix
branch
from
bb23a92 to
f94517c
Compare
dennisYatunin
force-pushed
the
dy/jfnk_bugfix
branch
from
f94517c to
6a67500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
Krylov.ktypeof(::FieldVector)so that the Jacobian-free Newton Krylov method used in CliMA/ClimaAtmos.jl#3976 works on GPUs. It also fixes a typo in the definitionClimaComms.context(::FieldVector), whereFix1was used in place ofFix2.