Skip to content

Introduce validation to the ColumnArray constructor #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce validation to the ColumnArray constructor #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions clickhouse/columns/array.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,20 @@ ColumnArray::ColumnArray(ColumnRef data, std::shared_ptr<ColumnUInt64> offsets)
, data_(data)
, offsets_(offsets)
{
const auto rows = offsets_->Size();
const auto expected_values = rows > 0 ? offsets_->At(rows - 1) : 0;
std::uint64_t prev = 0;
// Ensure the offset array is internally consistent
for (const auto& o : offsets_->GetWritableData()) {
if (o < prev) {
throw ValidationError("offsets must be monotonically increasing");
}
prev = o;
}
if (data_->Size() != expected_values) {
throw ValidationError("Mismatch between data and offsets: Expected " + std::to_string(expected_values) +
" values in data, but got " + std::to_string(data_->Size()));
}
}

ColumnArray::ColumnArray(ColumnArray&& other)
Expand Down
Loading