Always send empty array, even if underlying isn't nullable

ClickHouse · Jan 10, 2024 · 30fb894 · 30fb894
1 parent 6d87967
commit 30fb894
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/main/java/com/clickhouse/kafka/connect/sink/db/ClickHouseWriter.java b/src/main/java/com/clickhouse/kafka/connect/sink/db/ClickHouseWriter.java
@@ -350,7 +350,7 @@ private void doWriteCol(Record record, Column col, ClickHousePipedOutputStream s
                 BinaryStreamUtils.writeNonNull(stream);
             }
             if (!col.isNullable() && value.getObject() == null) {
-                if (colType == Type.ARRAY && col.getSubType().isNullable())
+                if (colType == Type.ARRAY)
                     BinaryStreamUtils.writeNonNull(stream);
                 else
                     throw new RuntimeException(String.format("An attempt to write null into not nullable column '%s'", col.getName()));

diff --git a/src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskWithSchemaTest.java b/src/test/java/com/clickhouse/kafka/connect/sink/ClickHouseSinkTaskWithSchemaTest.java
@@ -131,8 +131,10 @@ public void nullArrayTypeTest() {
 
         ClickHouseSinkTask chst = new ClickHouseSinkTask();
         chst.start(props);
-        assertThrowsExactly(RuntimeException.class, () -> chst.put(sr), "An attempt to write null into not nullable column 'arr'");
+        chst.put(sr);
         chst.stop();
+
+        assertEquals(sr.size(), ClickHouseTestHelpers.countRows(chc, topic));
     }
 
     @Test