Force async_insert=0 when setting the exactlyOnce keeper values #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
requested changes
Jan 12, 2024
mshustov
reviewed
Jan 19, 2024
| @@ -109,7 +109,7 @@ public void setStateRecord(StateRecord stateRecord) { | |||
| long maxOffset = stateRecord.getMaxOffset(); | |||
| String key = stateRecord.getTopicAndPartitionKey(); | |||
| String state = stateRecord.getState().toString(); | |||
| String insertStr = String.format("INSERT INTO `%s` values ('%s', %d, %d, '%s');", csc.getZkDatabase() ,key, minOffset, maxOffset, state); | |||
| String insertStr = String.format("INSERT INTO `%s` SETTINGS wait_for_async_insert=1 VALUES ('%s', %d, %d, '%s');", csc.getZkDatabase() ,key, minOffset, maxOffset, state); | |||
There was a problem hiding this comment.
How does ClickHouse handle the setting in the case of synchronous insert?
There was a problem hiding this comment.
When I checked the documentation (and when I ran it) I didn't see any issues - that's actually the default value. I just had it to force it, in case someone decides to disable.
mshustov
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete items not relevant to your PR: