Fix Numeric Data Type Loading in Power BI #478
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slabko
force-pushed
the
unique-type-names
branch
6 times, most recently
from
56713a8 to
55bf285
Compare
Update SQLGetTypeInfo results to comply with [SQLGetTypeInfo](https://learn.microsoft.com/en-us/sql/odbc/reference/syntax/sqlgettypeinfo-function). Applications must use the type names returned in the TYPE_NAME column of the SQLGetTypeInfo result set in ALTER TABLE and CREATE TABLE statements
SQLColumns should return a dataset with columns of specific types. If incorrect types are returned, some applications fail to deduce column types and either ignore them or treat them as binary data. This change ensures each column in the SQLColumns result is converted to the expected type.
slabko
force-pushed
the
unique-type-names
branch
from
1774ca4 to
50c168b
Compare
slabko
changed the title
|
discussed offline: we need to test how the existing dashboards react to the data type mapping changes |
|
Unfortunately, after testing, we noticed that this change breaks the MS Power BI Direct Query aggregation functions, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS Power BI and other applications were not able to recognize the types of uncommon SQL-world data types, such as
UInt8orInt64. It was unable to parse the data types fromSQLColumnsbecause the dataset returned by this function did not comply with the requirements. This is fixed by changing theSQLColumnsdataset.Additionally,
SQLGetTypeInforeturned SQL types such asINT,SMALLINT,BIGINT, etc. Each of these types had to have two entries in theSQLGetTypeInforesult: one for signed and one for unsigned types. This duplication confused MS Power BI. The fix for this issue involved following the documentation and using database-native types such asInt32,UInt64, etc.