fix: warn on unauthenticated public cloakserve binds#235
Closed
honor2030 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Scope note to keep the cloakserve queue easier to review. This PR is intentionally warning-only: it does not add authentication or change access control. It just surfaces the existing risk in startup logs and the root diagnostics when I saw that #248 touches the same cloakserve surface with a broader |
Contributor
|
Closing in favor of #248 which includes this warning plus opt-in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /diagnostics so unsafe CDP exposure is visible.Test Plan
python -m pytest tests/test_cloakserve.py::TestBindSecurityWarnings -qfailed before implementation withAttributeError: module 'cloakserve' has no attribute '_bind_security_warnings'.python -m pytest tests/test_cloakserve.py -q→56 passed.python -m py_compile bin/cloakservegit diff --checkNotes
tests/test_cloakserve.pyfor a separate_default_data_dirassertion plus archive/doctor CLI files; this PR keeps the scope to cloakserve public-bind diagnostics.python -m pytest -qis blocked by the local environment missing the optionalplaywrightdependency (ModuleNotFoundError: No module named 'playwright').