fix: allow shared playwright instance across launch calls#445
Open
siddhant-bayas wants to merge 2 commits into
Open
fix: allow shared playwright instance across launch calls#445siddhant-bayas wants to merge 2 commits into
siddhant-bayas wants to merge 2 commits into
Conversation
fix: allow shared playwright instance across launch calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each launch_context_async() call spawns its own node.js driver process. calling it multiple times creates multiple processes — more memory, more cpu, more overhead. this is an api misuse that the current api silently enables.
adds optional playwright= parameter to launch(), launch_async(), launch_context(), and launch_context_async(). when provided, reuses the existing driver process instead of spawning a new one. caller owns the lifecycle — closing a context with a shared instance does not stop the playwright driver.
before:
ctx1 = await launch_context_async() ctx2 = await launch_context_async() # second node.js processafter:
async with async_playwright() as p: ctx1 = await launch_context_async(playwright=p) ctx2 = await launch_context_async(playwright=p) # shared driver