Added some try for Template pattern #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cotel
requested review from
ConradoMateu,
Martrout96,
Starkie,
frnlpz,
josegarm,
pedrodaviddev,
srgtrujillo and
tonilopezmr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #44
We need to discuss if this is really a template because I am not convinced.
I doubt because in this case nothing should change in concrete templates, they just call their respective services.
On the other hand, the original responsability of a controller is to handle the request, and the template delegates how this request must be solved into its concrete controllers.
I didn't write any test in case we don't follow this example. Also I don't know how to test this mini beast I coded in 20 minutes 😆