fix: support pull_request_target in mention-check event handler#176
Closed
mvvmm wants to merge 1 commit into
Closed
fix: support pull_request_target in mention-check event handler#176mvvmm wants to merge 1 commit into
mvvmm wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175.
The
Check mentionsstep'scasestatement didn't includepull_request_target, causing it to hit the*)catch-all and setskip=true. This made the action silently do nothing when triggered bypull_request_targetevents.pull_request_targetis the correct event for auto-triggering bonk on PR open when security matters — it runs the workflow from the base branch (production) rather than the PR's head branch, preventing PR authors from modifying the workflow to change bonk's behaviour.Change: One line — add
pull_request_targetto the no-mention-needed event list alongsidepull_request.