CP-34996: change deployment strategy for agent when persistent volume is enabled #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-cz
changed the title
This mostly just adds some tests to the persistent volume support to
make sure it continues to work as expected. However, I also changed
the conditional to be based on server.persistentVolume.enabled instead
of requiring server.persistentVolume to be set to {}.
roberthocking
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #511 for context.
I mostly just added some tests and some schema validation, but I did also tweak the condition from
if .Values.server.persistentVolumetoif .Values.server.persistentVolume.enabled.