Skip to content

Dev: utils: Reuse methods in xmlutil.CrmMonXmlParser #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Dev: utils: Reuse methods in xmlutil.CrmMonXmlParser #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c665a16
Dev: utils: Reuse methods in xmlutil.CrmMonXmlParser
liangxin1300 Oct 23, 2025
6655669
Dev: crash_test: Reuse get_node_list in xmlutil.CrmMonXmlParser
liangxin1300 Oct 24, 2025
2872014
Dev: unittests: Adjust unit test for previous commit
liangxin1300 Oct 23, 2025
b29bbba
Dev: crash_test: Removed unused codes related to check.py
liangxin1300 Oct 27, 2025
a409023
Dev: unittests: Remove related unit test for the removed codes in cra…
liangxin1300 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
317 changes: 0 additions & 317 deletions crmsh/crash_test/check.py
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion crmsh/crash_test/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,3 @@
REMOVE_PORT = "firewall-cmd --zone=public --remove-port={port}/udp"
ADD_PORT = "firewall-cmd --zone=public --add-port={port}/udp"
SBD_CONF = "/etc/sysconfig/sbd"
SBD_CHECK_CMD = "sbd -d {dev} dump"
8 changes: 0 additions & 8 deletions crmsh/crash_test/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import argparse
from argparse import RawDescriptionHelpFormatter

from . import check
from . import utils
from . import task
from crmsh import utils as crmshutils
Expand All @@ -30,8 +29,6 @@ def __init__(self):
self.current_case = None

# set by argparse(functions)
self.check_conf = None
self.cluster_check = None
self.sbd = None
self.corosync = None
self.pacemakerd = None
Expand Down Expand Up @@ -142,9 +139,6 @@ def parse_argument(context):
context.jsonfile,
context.report_path))

#parser.add_argument('-c', '--check-conf', dest='check_conf', action='store_true',
# help='Validate the configurations')

group_mutual = parser.add_mutually_exclusive_group()
group_mutual.add_argument('--kill-sbd', dest='sbd', action='store_true',
help='Kill sbd daemon')
Expand Down Expand Up @@ -198,8 +192,6 @@ def run(context):
os.makedirs(context.var_dir, exist_ok=True)

try:
check.fix(context)
check.check(context)
kill_process(context)
fence_node(context)
split_brain(context)
Expand Down
Loading