Skip to content

[crmsh-5.0] Fix: migration: Avoid exception inside thread #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: crmsh-5.0
Choose a base branch
from
Draft

[crmsh-5.0] Fix: migration: Avoid exception inside thread #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crmsh/migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,12 @@ def check_local(handler: CheckResultHandler):

def check_remote():
handler = CheckResultInteractiveHandler()
nodes = utils.list_cluster_nodes_except_me()
class CheckRemoteThread(threading.Thread):
def run(self):
self.result = prun.prun({
node: 'crm cluster health sles16 --local --json=oneline'
for node in utils.list_cluster_nodes_except_me()
for node in nodes
})
prun_thread = CheckRemoteThread()
prun_thread.start()
Expand Down