Draft
Conversation
…omponent to allow for reactive time changing automatically Co-authored-by: Kaylee Wu <kayleewuhu@users.noreply.github.com>
…te or supervisor times
circlegov
reviewed
Oct 8, 2023
| // 1. associate submitted a time, and supervisor did not | ||
| // 2. Supervisor submitted a time for this entry, and associate did not | ||
| // 3. Associate time and supervisor reported time differ | ||
| var hasConflict = hasAssociateTime !== hasSupervisorTime || |
Contributor
There was a problem hiding this comment.
possible issue of associate has time and supervisor doesnt which shouldn't lead to a conflict
circlegov
reviewed
Oct 8, 2023
| * and allows for conflicts to be shown. | ||
| */ | ||
| export function ConflicatableTimeEntry(props: ConflicatableTimeEntryProps) { | ||
| const [selectedTime, setSelectedTime] = useState(null); |
circlegov
reviewed
Oct 8, 2023
| export function TimeConflictPopup(props: TimeConflictPopupProps) { | ||
| const { isOpen, onOpen, onClose } = useDisclosure(); | ||
|
|
||
| const hasAssociateTime: boolean = props.associateEntry !== undefined && props.associateEntry !== null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes clickup ticket link
📝 Description
Briefly list the changes made to the code:
Added support for this.
And removed redunant use of that.
Also this was included for reasons.
✔️ Testing
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!