Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #7
📝 Description
This PR implements a dedicated repository layer for donations to handle complex database queries, pagination, filtering, and aggregations.
Changes made:
Created DonationsRepository class with 5 required methods for data access operations
Implemented findPaginated() with flexible filtering (by donation type, amount range, date range, anonymity status, and recurring intervals)
Added searchByDonorNameOrEmail() for case-insensitive search across donor name and email fields
Built getTotalsByDateRange() to calculate aggregate totals and counts for specific date ranges
Implemented findRecentPublic() that returns privacy-aware public donations (r
Wrote unit test suite with 20+ test cases covering all methods and edge cases
Used TypeORM QueryBuilder for efficient, type-safe database queries
✔️ Verification
Run npm test donations.repository.spec.ts to execute the full test suite
All 20+ tests should pass
Pagination logic with various page sizes and filters
Search functionality with multiple field matching
Aggregate calculations (sum, count) with null handling
Delete operations with error cases
Query builder method call verification