Skip to content

Application Status Change + Forms Sent -> Forms Signed#234

Open
SamNie2027 wants to merge 3 commits intomainfrom
230-status-change
Open

Application Status Change + Forms Sent -> Forms Signed#234
SamNie2027 wants to merge 3 commits intomainfrom
230-status-change

Conversation

@SamNie2027
Copy link
Copy Markdown
Collaborator

@SamNie2027 SamNie2027 commented Apr 3, 2026

ℹ️ Issue

Closes #233

📝 Description

Briefly list the changes made to the code:

  1. Added a status change dropdown component with the same colors as the design, then added it into the admin view application view.
  2. Added a poppup with the same look as the design from the dropdown that has a confirm or cancellation button.
  3. Added a helper function in apiClient to call the status change in the backend.
  4. Changed Forms Sent enum value in the AppStatus to Forms Signed as we agreed with the client recently.
  5. Created a new database migration to reflect this change above.
  6. Also capitalized some of the enum values for statuses as the capitalization was previously inconsistent.

✔️ Verification

Verified that performing a status change to every single enumerated enum caused a confirmation poppup to appear
Confirmed that pressing confirm on the poppup changed the selected status, as well as the status in the database
Confirmed that pressing cancel on the poppup did NOT change the selected status nor the status in the database

🏕️ (Optional) Future Work / Notes

Copilot used to help with frontend work.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an admin-facing application status control to the frontend and aligns application status enum values across frontend/backend/database (including renaming “Forms Sent” → “Forms Signed”).

Changes:

  • Added an ApplicantStageControl dropdown + confirmation popover and wired it into the admin application view.
  • Added a frontend API client helper to PATCH an application’s status.
  • Updated AppStatus enum values (capitalization + “Forms Signed”) and introduced a DB migration to update the Postgres enum.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/frontend/vite.config.ts Expands Vite dev server filesystem allowlist for monorepo file access.
apps/frontend/src/containers/AdminViewApplication.tsx Wires the new status control into the admin application view and calls the API to persist changes.
apps/frontend/src/components/SchoolAffiliationFrame.tsx Adds an optional statusControl slot to render the dropdown in the header area.
apps/frontend/src/components/ApplicantStageControl.tsx New status dropdown component with confirmation popover and error handling.
apps/frontend/src/api/types.ts Renames/recapitalizes AppStatus enum string values (incl. FORMS_SIGNED).
apps/frontend/src/api/apiClient.ts Adds updateApplicationStatus() PATCH helper.
apps/backend/src/migrations/1775221059185-AlterApplication.ts New migration attempting to replace/rename the Postgres application_appstatus_enum.
apps/backend/src/applications/types.ts Renames/recapitalizes backend AppStatus enum string values (incl. FORMS_SIGNED).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review Front End PRs

2 participants