Application Status Change + Forms Sent -> Forms Signed#234
Open
SamNie2027 wants to merge 3 commits intomainfrom
Open
Application Status Change + Forms Sent -> Forms Signed#234SamNie2027 wants to merge 3 commits intomainfrom
SamNie2027 wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an admin-facing application status control to the frontend and aligns application status enum values across frontend/backend/database (including renaming “Forms Sent” → “Forms Signed”).
Changes:
- Added an
ApplicantStageControldropdown + confirmation popover and wired it into the admin application view. - Added a frontend API client helper to PATCH an application’s status.
- Updated
AppStatusenum values (capitalization + “Forms Signed”) and introduced a DB migration to update the Postgres enum.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/frontend/vite.config.ts | Expands Vite dev server filesystem allowlist for monorepo file access. |
| apps/frontend/src/containers/AdminViewApplication.tsx | Wires the new status control into the admin application view and calls the API to persist changes. |
| apps/frontend/src/components/SchoolAffiliationFrame.tsx | Adds an optional statusControl slot to render the dropdown in the header area. |
| apps/frontend/src/components/ApplicantStageControl.tsx | New status dropdown component with confirmation popover and error handling. |
| apps/frontend/src/api/types.ts | Renames/recapitalizes AppStatus enum string values (incl. FORMS_SIGNED). |
| apps/frontend/src/api/apiClient.ts | Adds updateApplicationStatus() PATCH helper. |
| apps/backend/src/migrations/1775221059185-AlterApplication.ts | New migration attempting to replace/rename the Postgres application_appstatus_enum. |
| apps/backend/src/applications/types.ts | Renames/recapitalizes backend AppStatus enum string values (incl. FORMS_SIGNED). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #233
📝 Description
Briefly list the changes made to the code:
✔️ Verification
Verified that performing a status change to every single enumerated enum caused a confirmation poppup to appear
Confirmed that pressing confirm on the poppup changed the selected status, as well as the status in the database
Confirmed that pressing cancel on the poppup did NOT change the selected status nor the status in the database
🏕️ (Optional) Future Work / Notes
Copilot used to help with frontend work.