SSF-181 Volunteer Request Management Frontend#152
Conversation
* fix getFMDonations endpoint (#150) * [SSF-171] update volunteers endpoint (#138) * update volunteers endpoint * comments * comments * initial comments * fix findByIds methods * comments * last things * comments * final comments * SSF-153 Volunteer Create Order Endpoint (#126) * logic for creating order itself * functionality for creating allocations and updating donation item reserved quantities * finish route functionality * all tests except create order service test * finish test * touch ups * comments * comment * comments * comments * fix import bug * import * import fix * comment * remove controller endpoints * comments * making transaction naming clear * comment * format * comments * comments * fix tests * commetns * simplify duplicate check --------- Co-authored-by: Amy Wang <147568742+amywng@users.noreply.github.com>
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
page looks great so far. everything functions so beautifully! just some small changes.
apps/frontend/src/components/forms/volunteerCloseRequestModal.tsx
Outdated
Show resolved
Hide resolved
| onOrderCreate: () => void; | ||
| } | ||
|
|
||
| const CreateNewOrderModal: React.FC<CreateNewOrderModalModalProps> = ({ |
There was a problem hiding this comment.
I think we forgot to account for this failure mode: https://www.figma.com/design/brc5luMhizIFp893XIutYe/SP26---SSF-Designs?node-id=1891-21449&m=dev
There was a problem hiding this comment.
I instead have it so you cannot allocate over the max amount so it should never reach that case, like if there is only 75 available quantity you cannot type over 75
There was a problem hiding this comment.
I should've rephrased that better. This failure mode is accounted for, but I guess differs from the design a decent bit. Can you just make sure with Priya that she's fine with us just limiting what can be input, as opposed to a message?
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
one thing that needs changing, aside from that it looks great. ty justinnnnn 🪮 🔒 🧶
| mx={3} | ||
| /> | ||
|
|
||
| <Input |
There was a problem hiding this comment.
For me, the number and the ticker is not centered:
If Priya is good with this design, we just need to center this (up and down errors should be all the way to the right, with the number in the center).
2 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-181
📝 Description
I added the full frontend for Volunteer Food Request Management which included an action modal, a close request modal, and a new order modal.
The relative frontend route is /volunteer-request-management
✔️ Verification
I made sure the design aligned with figma and all functionality with closing requests and adding new orders worked.
🏕️ (Optional) Future Work / Notes
N/A