[SSF-64] Volunteer Backend Updates by amywng · Pull Request #52 · Code-4-Community/ssf

amywng · 2025-10-09T21:04:41Z

ℹ️ Issue

Closes SSF-64

📝 Description

Updated GET /users/volunteers to return a volunteer's assigned pantry IDs
Added GET /users/{id}/pantries endpoint to get pantry info about volunteer's assigned pantries
Added PATCH /users/{id}/pantries endpoint to assign list of pantries to a volunteer

✔️ Verification

🏕️ (Optional) Future Work / Notes

Need to write tests.

apps/backend/src/migrations/1760033134668-AddVolunteerPantryUniqueConstraint.ts

apps/backend/src/users/users.service.ts

dburkhart07 · 2025-10-11T17:48:47Z

apps/backend/src/volunteerAssignments/volunteerAssignments.entity.ts

+  @PrimaryColumn({ name: 'pantry_id' })
+  pantryId: number;
+
+  @ManyToOne(() => User, { nullable: false, onDelete: 'CASCADE' })


Note for @sam-schu : I did not know about this onDelete: 'CASCADE' feature. For future work, should look into other entities to see where we may want to add this, as its quite useful.

me neither!

dburkhart07

LGTM!

dburkhart07

Few changes that I think would be helpful! Other than that lgtm!

apps/frontend/src/types/types.ts

apps/backend/src/volunteerAssignments/volunteerAssignments.entity.ts

apps/backend/src/users/users.controller.ts

apps/backend/src/users/users.module.ts

apps/backend/src/users/users.controller.ts

dburkhart07

Few small changes

apps/backend/src/users/users.service.ts

apps/backend/src/users/users.controller.ts

apps/backend/src/users/users.controller.spec.ts

apps/backend/src/users/users.module.ts

dburkhart07

Few final changes!

apps/backend/src/users/users.service.spec.ts

apps/backend/src/users/users.controller.spec.ts

apps/backend/src/users/users.controller.ts

dburkhart07

2 small changes to make, but other than that lgtm!! 🍡 🔢

apps/backend/src/users/users.controller.spec.ts

apps/backend/src/users/users.service.ts

sam-schu

Initial thoughts:

Could we simplify some of the users service logic by adding into the user entity a many-to-many relationship with pantries that would allow you to directly access all the pantries assigned to a volunteer through the user repo? Going through the user repo should be cleaner than having to manually access the junction table
With any remaining logic that requires directly accessing the assignments or pantry entities (hopefully not that much), could we make service functions in the corresponding services for that logic so we only directly access the user repo in the users service?

apps/backend/src/migrations/1760033134668-AddVolunteerPantryUniqueConstraint.ts

apps/backend/src/users/users.service.ts

sam-schu · 2025-11-29T04:36:17Z

apps/backend/src/volunteerAssignments/volunteerAssignments.entity.ts

+  @PrimaryColumn({ name: 'pantry_id' })
+  pantryId: number;
+
+  @ManyToOne(() => User, { nullable: false, onDelete: 'CASCADE' })


me neither!

dburkhart07

Few small changes 🥜

apps/frontend/src/types/types.ts

apps/backend/src/users/users.service.ts

dburkhart07

LGTM!! 🎲

sam-schu

Just two nits, looks great! Awesome we're getting rid of a whole module :)

apps/backend/src/users/users.service.ts

…kend [SSF-64] Volunteer Backend Updates

dburkhart07 requested changes Oct 11, 2025

View reviewed changes

dburkhart07 approved these changes Oct 11, 2025

View reviewed changes

dburkhart07 added the medium priority label Nov 18, 2025

amywng added the on hold label Nov 21, 2025

sam-schu added blocked and removed on hold labels Nov 21, 2025

dburkhart07 requested changes Nov 22, 2025

View reviewed changes

amywng force-pushed the acw/SSF-64-volunteer-backend branch 3 times, most recently from b5d2a30 to 619fbf3 Compare November 26, 2025 17:38

amywng removed the blocked label Nov 26, 2025

amywng requested review from dburkhart07 and sam-schu November 26, 2025 19:19

dburkhart07 requested changes Nov 27, 2025

View reviewed changes

amywng requested a review from dburkhart07 November 27, 2025 01:48

dburkhart07 requested changes Nov 27, 2025

View reviewed changes

amywng requested a review from dburkhart07 November 28, 2025 12:57

dburkhart07 approved these changes Nov 29, 2025

View reviewed changes

apps/backend/src/users/users.controller.spec.ts Outdated Show resolved Hide resolved

apps/backend/src/users/users.service.ts Show resolved Hide resolved

sam-schu requested changes Nov 29, 2025

View reviewed changes

amywng force-pushed the acw/SSF-64-volunteer-backend branch from 49f97bb to 192c9a5 Compare November 29, 2025 20:23

amywng requested review from dburkhart07 and sam-schu November 29, 2025 20:23

amywng force-pushed the acw/SSF-64-volunteer-backend branch from 113d065 to 1205abc Compare November 29, 2025 21:39

dburkhart07 requested changes Nov 30, 2025

View reviewed changes

apps/frontend/src/types/types.ts Show resolved Hide resolved

apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved

apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved

amywng requested a review from dburkhart07 November 30, 2025 18:53

amywng force-pushed the acw/SSF-64-volunteer-backend branch from b13da6b to 8600652 Compare November 30, 2025 21:11

amywng added 4 commits November 30, 2025 19:39

volunteer backend updates minus tests

50b0bc3

review comments

e54b6a3

review comments

d892138

prettier

297797d

amywng added 13 commits November 30, 2025 19:39

add tests and prettier

1bea938

prettier

50b174f

review comments

1a74893

review comments

38b0641

change to singular repo

2db8cec

change to singular repo

8038102

remove unnecessary logic check

b2d2642

add many to many relation and remove direct usage of pantry repo

32fb226

remove volunteer assignment route and assigning duplicate pantries

5d83fb8

prettier

20e91e8

switch colon to comma in migration

b2a6074

update user service methods and frontend types

62e7416

prettier

76c4a47

amywng force-pushed the acw/SSF-64-volunteer-backend branch from 8600652 to 76c4a47 Compare December 1, 2025 00:39

dburkhart07 approved these changes Dec 1, 2025

View reviewed changes

sam-schu approved these changes Dec 4, 2025

View reviewed changes

apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved

apps/backend/src/users/users.service.ts Outdated Show resolved Hide resolved

remove redundant validation

9d274e5

amywng merged commit bc0f539 into main Dec 4, 2025
1 check failed

amywng deleted the acw/SSF-64-volunteer-backend branch December 4, 2025 02:03

swarkewalia pushed a commit that referenced this pull request Jan 18, 2026

Merge pull request #52 from Code-4-Community/acw/SSF-64-volunteer-bac…

191ad24

…kend [SSF-64] Volunteer Backend Updates

Conversation

amywng commented Oct 9, 2025

ℹ️ Issue

📝 Description

✔️ Verification

🏕️ (Optional) Future Work / Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

sam-schu Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sam-schu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sam-schu Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dburkhart07 left a comment

Choose a reason for hiding this comment

Uh oh!

sam-schu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sam-schu left a comment •

edited

Loading